go-spacemesh
go-spacemesh copied to clipboard
build(deps): Bump ubuntu from 22.04 to 24.04
Bumps ubuntu from 22.04 to 24.04.
You can trigger a rebase of this PR by commenting @dependabot rebase
.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
-
@dependabot rebase
will rebase this PR -
@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it -
@dependabot merge
will merge this PR after your CI passes on it -
@dependabot squash and merge
will squash and merge this PR after your CI passes on it -
@dependabot cancel merge
will cancel a previously requested merge and block automerging -
@dependabot reopen
will reopen this PR if it is closed -
@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually -
@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency -
@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) -
@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) -
@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
@fasmat I think we could merge this no?
@fasmat I think we could merge this no?
I kinda want to stick with ubuntu 22.04 for a while longer, partially because ubuntu-latest
still points to ubuntu-22.04
and not ubuntu-24.04
.
However the main reason is that the version we build on is the oldest version that we support - building go-spacemesh
on ubuntu-22.04
results in a binary that will run on both jammy and noble, but building it on ubuntu-24.04
will result in a binary that only runs on noble (due to our dependency on native code we use with cgo
).
ubuntu-22.04
will be supported by GH for another 2 years and I'd prefer waiting at least until next year before we upgrade to noble and drop support for jammy. Does ubuntu-24.04
have anything of importance for us besides being the newer OS?
PS.: I'd also like to wait a bit in regards with upgrading go versions and not immediately update to the next version every 6 months - we can stay with old stable for a while and upgrade with 2-3 months delay to make sure libraries and tools we use have been updated for the newest go version 🙂
Sure. Makes sense.
@fasmat but this PR is updating Ubuntu in Dockerfiles. We would still build artifacts using Ubuntu 22.04. Nobody is taking the binary from the docker image and running it on Ubuntu 22.
@fasmat but this PR is updating Ubuntu in Dockerfiles. We would still build artifacts using Ubuntu 22.04. Nobody is taking the binary from the docker image and running it on Ubuntu 22.
Yes I know. But why should we build our binary releases on a different platform than our docker images? Is there any advantage to using Noble as docker image base? I see little upside in using a different OS base for docker than for the binary releases, but a possible (albeit unlikey) downside: small differences between the two versions of ubuntu, possibly requiring us to account for them or running into bugs that only happen in the docker / binary release and not in the other...
@fasmat but this PR is updating Ubuntu in Dockerfiles. We would still build artifacts using Ubuntu 22.04. Nobody is taking the binary from the docker image and running it on Ubuntu 22.
Yes I know. But why should we build our binary releases on a different platform than our docker images? Is there any advantage to using Noble as docker image base? I see little upside in using a different OS base for docker than for the binary releases, but a possible (albeit unlikey) downside: small differences between the two versions of ubuntu, possibly requiring us to account for them or running into bugs that only happen in the docker / binary release and not in the other...
If there are doubts that our code might not work on Ubuntu-24, we should either explicitly not support it or test it on ubuntu-24 as well (I prefer the latter). Wdyt?
If there are doubts that our code might not work on Ubuntu-24, we should either explicitly not support it or test it on ubuntu-24 as well (I prefer the latter). Wdyt?
Sure, feel free to start testing - I just don't see why we have to rush to update when Jammy is still supported for another 3 years, and there are other more urgent tasks 🙂