go-spacemesh icon indicating copy to clipboard operation
go-spacemesh copied to clipboard

Do not try to publish proofs for malicious ATXs during sync

Open ivan4th opened this issue 1 year ago • 3 comments

Motivation

Publishing is blocked during sync because Syncer::ListenToATXGossip() returns false, and thus every malicious ATX being synced is causing an error resulting in an interruption of sync.

Description

Do not try to publish ATX malfeasance proofs during sync.

Test Plan

Sync a test node, look for sync interruptions / errors

ivan4th avatar Feb 19 '24 20:02 ivan4th

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0c4c55d) 79.6% compared to head (6c98cf4) 79.7%. Report is 4 commits behind head on develop.

Files Patch % Lines
activation/handler.go 78.1% 12 Missing and 2 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5586   +/-   ##
=======================================
  Coverage     79.6%   79.7%           
=======================================
  Files          270     270           
  Lines        27186   27199   +13     
=======================================
+ Hits         21667   21688   +21     
+ Misses        3973    3967    -6     
+ Partials      1546    1544    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 19 '24 20:02 codecov[bot]

bors try

ivan4th avatar Feb 19 '24 22:02 ivan4th

try

Build succeeded:

spacemesh-bors[bot] avatar Feb 19 '24 23:02 spacemesh-bors[bot]

@ivan4th should we merge the change?

dshulyak avatar Feb 26 '24 15:02 dshulyak

Yes, let's merge

ivan4th avatar Feb 26 '24 15:02 ivan4th

bors merge

ivan4th avatar Feb 26 '24 15:02 ivan4th

Pull request successfully merged into develop.

Build succeeded:

spacemesh-bors[bot] avatar Feb 26 '24 16:02 spacemesh-bors[bot]