go-spacemesh icon indicating copy to clipboard operation
go-spacemesh copied to clipboard

Node should *not* delete POST files when there is more on a disk than configured

Open pigmej opened this issue 1 year ago • 9 comments

In the situation when there are more post files than node expects node should error and give up, and not delete the files.

That should help not surprise users with "your data is gone because config was wrong".

In the situation when there are too less files, then node should clearly indicate that it will generate more.

There probably should be a flag that would change node behavior:

  • --do-not-touch-pos and then it should fail regardless of the found situation on the disk (smaller, bigger etc).
  • we could have a flag that would keep current behaviour too.

pigmej avatar Jun 26 '23 07:06 pigmej

I just lost 1 TiB post data due to this "feature" - please fix this ASAP!

schinzelh avatar Jul 25 '23 06:07 schinzelh

See also https://github.com/spacemeshos/post/issues/236

lrettig avatar Sep 13 '23 18:09 lrettig

It will be addressed with https://github.com/spacemeshos/pm/issues/259

pigmej avatar Sep 25 '23 12:09 pigmej

This is still happening

lrettig avatar Sep 28 '23 16:09 lrettig

I lost 4TiB today, when will you fix it? --do-not-touch-pos should be default behavior. there's so many complains since testnet, more than 6 month later the issue haven't been fixed

Stizerg avatar Dec 01 '23 10:12 Stizerg

Post-service implementation will have that fixed, as mentioned https://github.com/spacemeshos/go-spacemesh/issues/4594#issuecomment-1733625198

pigmej avatar Dec 04 '23 11:12 pigmej

I believe the issue could be resolved in less than 10 minutes; however, it seems there is a lack of willingness to address user concerns promptly.

ytx1991 avatar Dec 27 '23 07:12 ytx1991

I believe the issue could be resolved in less than 10 minutes; however, it seems there is a lack of willingness to address user concerns promptly.

Our small development team is very busy focusing on network stability. This is an open source project. Feel free to make the desired change and submit it as a PR here! We're more than happy to review.

For the record, if it were a "ten minute change" we would've made it a long time ago. The change is more complex as it ties into the post service work that @pigmej mentioned above.

lrettig avatar Dec 27 '23 18:12 lrettig

This is fully solved with post-service.

pigmej avatar Feb 11 '24 17:02 pigmej