spacedrive
spacedrive copied to clipboard
spacedriveapp
[ENG-770 / ENG-773] Copy/paste / Explorer context menu duplicate
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| spacedrive-web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 22, 2023 11:34pm |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| spacedrive-landing | ⬜️ Ignored (Inspect) | Visit Preview | Jun 22, 2023 11:34pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Just tested this and everything seems to work. We do need to hide FS actions on Overview though.
Just tested this and everything seems to work. We do need to hide FS actions on Overview though.
I am working on it, also fixing a small bug I found in this PR. Will commit all the changes here as they are related
So, I added the checks for hiding the FS actions in the Overview and the MediaView. I also added error handling to all the actions in the context menus, so that the user has some feedback when things fail. The actions seem to be working as intended from what I could observe from my tests. However, there are 3 points we should look into (don't know if in this PR or another):
-
Errors that occur in the paste action are not raised to the front. This happens due to the action running inside a job, which the API route does not wait for (which I think is on purpose). Maybe we should change this in the front to be some kind of subscription, so the user has some feedback if any error occurs when pasting files.
-
~Cutting files does not automatically update the file list in the destination. The file is removed from the origin, but only shows up in the destination after a re-scan~ (Fixed)
-
Duplicate / Copying a file to the same folder, creates a suffixed copy of the file, however that only work once, as the suffix is hard-coded and it doesn't take into account other previous copies of the same file already present.
I tried pretty hard to reproduce this faulty cut behavior but failed hard lol. Both on my Linux and Mac machines it works as expected.
Regarding the other points, they're more improvements than problems so we can address them later and we sholdn't postpone our alpha release anymore.
Actually just found out, just happens on Linux if you cut and paste between different locations. It's a watcher bug