spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-737] Location deletion hanging

Open brxken128 opened this issue 1 year ago • 3 comments

Deleting large locations often took a long time, and I believe it was just a simple concurrency issue. I've done some testing myself, but will keep this as a draft until I (and others) have validated the fix.

As far as I can tell, this is fixed - at least in dev with multiple large locations. I'm unable to test prod due to other issues, but more tests would be appreciated before merge.

brxken128 avatar Jun 20 '23 14:06 brxken128

ENG-737 Delete location takes forever

No errors, no logs and shows nothing to frontend. It's most likely timing out?

happens on big directories

linear[bot] avatar Jun 20 '23 14:06 linear[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 9:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2023 9:07am

vercel[bot] avatar Jun 20 '23 14:06 vercel[bot]

Drafting until I find the issue, it seems to still be happening.

brxken128 avatar Jun 20 '23 19:06 brxken128

Issue is a lot more complex than first thought, this cleans it up a little though.

brxken128 avatar Jun 21 '23 19:06 brxken128