spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Indexer rule `Git Projects` not working as expected

Open HeavenVolkoff opened this issue 2 years ago • 0 comments
trafficstars

Describe the bug

Hi,

While testing the UI that I implemented in #620 for informing indexer rules when adding locations, I noticed that the behavior of the Git Repositories rule seemed odd to me. I thought it would only hide the .git directory of any Git project. However, as far as I could test, it hid all normal files and directories, including the .git directory, and only showed the hidden files. Is this the correct behavior for this indexer rule?

Here are some screenshots of the same Location files with different indexer rules enabled:

  • Without indexer rule: photo_2023-03-18_15-57-10

  • With Reject Hidden Files rule: photo_2023-03-18_15-57-07

  • With Git Repositories rule: photo_2023-03-18_15-57-02

Reproduction

  1. Add a new Location pointing to a Git project directory and enable the Git Repositories indexer rule 2 . Only see hiden files and nothing else when opening the location

Expected behavior

IMHO I think the Git Repositories should only hide git related files and directories and index everything else.

Platform and versions

$> pnpm --version && cargo --version && rustc --version
7.29.3
cargo 1.68.0
rustc 1.68.0 (2c8cc3432 2023-03-06) (Arch Linux rust 1:1.68.0-1)

$> uname -a
Linux arch.shadowverse 6.2.6-201.fsync.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Mar 15 04:41:53 UTC 2023 x86_64 GNU/Linux

Stack trace

None

Additional context

None

HeavenVolkoff avatar Mar 18 '23 19:03 HeavenVolkoff