spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-294] Volume awareness

Open spacedrive-bot opened this issue 2 years ago • 4 comments

Current the Rust code that takes care of getting volumes mounted on the system is pretty bad, as least on macOS. It sometimes doesn't even show "Macintosh HD". I don't think we are considering volumes at the moment for anything other than statistics calculation, so that has not been an issue.

We will need to accurately track volumes as a file manager, but knowing how much available space across your whole network is definitely a core feature.

We have two options:

  • Write a custom Swift solution for macOS. This was how we did it originally, but it was removed for whatever reason.
  • Look deeper into a pure rust solution, as I remember the scope of packages available for this was limited and not accurate. This method will involve dealing with low level Objective C FFI bindings on Mac.

@maxichrome would be suited to option one, @ericson.ds999 might find this hard without a Mac.. could be an @oscar challenge? Jamie Pine on Linear

spacedrive-bot avatar Nov 05 '22 14:11 spacedrive-bot

Hello test

jamiepine avatar Nov 05 '22 14:11 jamiepine

I think a Swift solution would be the most welcome way of doing this, if there's not a better direct Rust route.

  • Objective C FFI bindings will be difficult to maintain and debug, and native bindings packages are outdated and by extension will need lots of effort to work with.
  • We already have working Swift bindings thanks to Brendan's swift-rs library. I see no issue taking this route.

I'll throw this onto my plate. Can we throw a deadline on this @jamie? maxichrome on Linear

spacedrive-bot avatar Nov 06 '22 09:11 spacedrive-bot

Seeing at-oscar and at-jamie on GitHub getting pinged seems like a fundamental flaw in our Linear-GitHub sync. @xPolar

maxichrome avatar Nov 06 '22 09:11 maxichrome

Swift would be the optimal solution, I think it was removed since it was deemed unnecessary. Shouldn't be any problem with bringing it back.

Brendonovich avatar Nov 06 '22 09:11 Brendonovich