spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[Eng 200] enter on keyboard doesn't cause modal to submit

Open MohammedBajuaifer opened this issue 2 years ago • 6 comments

This PR enables submission modals by using the "Enter Key". It also rerun the library queries when creating/removing libraries

Closes #332

MohammedBajuaifer avatar Sep 08 '22 20:09 MohammedBajuaifer

@MohammedBajuaifer is attempting to deploy a commit to the Spacedrive Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 08 '22 20:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
spacedrive-web ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 8:15PM (UTC)

vercel[bot] avatar Sep 08 '22 20:09 vercel[bot]

I think we should get the queryClient from the hook. Eg. const queryClient = useQueryClient(); instead of importing it directly.

oscartbeaumont avatar Sep 08 '22 20:09 oscartbeaumont

@oscartbeaumont updated PR

MohammedBajuaifer avatar Sep 08 '22 20:09 MohammedBajuaifer

@jamiepine @oscartbeaumont could this PR be rechecked.

xPolar avatar Sep 12 '22 23:09 xPolar

This looks like a better approach to what we have on main as with this we can control if the form can be submitted or not. (e.g. creating a library with no name)

utkubakir avatar Sep 26 '22 05:09 utkubakir