spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Video thumbnails

Open fogodev opened this issue 2 years ago • 3 comments

Introducing video files thumbnail generation webp images using ffmpeg

fogodev avatar Sep 05 '22 03:09 fogodev

ENG-231 Video thumbnails

Still images generated for video Object types using ffmpeg

linear[bot] avatar Sep 05 '22 03:09 linear[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
spacedrive-landing ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 8:04AM (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 8:04AM (UTC)

vercel[bot] avatar Sep 05 '22 03:09 vercel[bot]

CleanShot 2022-09-06 at 13 41 11@2x

I'm getting pretty bad thumbnails with my test files, also there's a casing issue on the query .MP4 would be ignored.

Very excited about this PR though!

jamiepine avatar Sep 06 '22 20:09 jamiepine

Not sure if the placement of this code matches what Brendan is doing for the sync lib, but it feels out of place either way. maybe core/crates/thumbnailer would work better?

edit: since core/prisma is a crate too I guess we don't need a crates directory, maybe just the rename will make it fit in better

jamiepine avatar Sep 23 '22 23:09 jamiepine

Not sure if the placement of this code matches what Brendan is doing for the sync lib

Nah I'm doing the same thing

Plz squash merge this PR lol

Brendonovich avatar Sep 24 '22 02:09 Brendonovich