spacedrive
spacedrive copied to clipboard
[ENG-210] Sidebar is transparent with no blur on Linux
Describe the bug
The sidebar for Spacedrive is transparent and not blurred like it's supposed to be (specifically on macOS).
Reproduction
-
git pull && pnpm i && pnpm prep && pnpm desktop dev
- Observe sidebar
Expected behavior
I'd assume that the sidebar background would just be a solid color because I don't think blur can be native on Linux (or Windows).
Platform and versions
➜ spacedrive git:(main) pnpm --version && cargo --version && rustc --version
7.5.2
cargo 1.61.0 (a028ae4 2022-04-29)
rustc 1.61.0 (fe5b13d68 2022-05-18)
➜ spacedrive git:(main) neofetch
///////////// matt@pop-os
///////////////////// -----------
///////*767//////////////// MS-7B98 1.0
//////7676767676*////////////// Pop!_OS 22.04 LTS
/////76767//7676767////////////// 6 hours, 34 mins
/////767676///*76767/////////////// kitty
///////767676///76767.///7676*/////// Catppuccin-Macchiato-Dark-BL
/////////767676//76767///767676//////// 12.32GiB / 31.29GiB (39%)
//////////76767676767////76767///////// Lil B - The Frozen Tape - Patrick Star
///////////76767676//////7676//////////
////////////,7676,///////767///////////
/////////////*7676///////76////////////
///////////////7676////////////////////
///////////////7676///767////////////
//////////////////////'////////////
//////.7676767676767676767,//////
/////767676767676767676767/////
///////////////////////////
/////////////////////
/////////////
### Stack trace
_No response_
### Additional context
_No response_
This also happened to me on Windows. I fixed it by changing the default value of this useState from 'macOS' to 'windows' here.
I think this variable isn't being set properly here.
cc: @maxichrome, I think this is an issue for you to handle. Haris on Linear
never got far on this repro bc of machine/test env issues, gonna look to repro again today unless anyone has notes that it's no longer an issue.
@brxken128? maxichrome on Linear
A while back I redid the variable that controls this behavior so potentially that or any other change could have fixed it which might explain if you can't reproduce it.
Is anyone still having this?
iirc the very first library creation page was transparent, but the sidebar is fully opaque (on fedora 37, gnome 43)
cool cool. on my first few successful windows builds it looks like that transparency issue you're talking about is present there too. worth looking into maxichrome on Linear
@brxken128 @maxichrome The very first library creation page (onboarding flow) is a placeholder (which is why it looks disgusting) and would explain why it is transparent. If that's the only issue I think we can close this issue. Someone has gotta build the onboarding page properly and when they do that it will fix that transparency issue.
Although that screenshot @brxken128 shared has way too much padding above the library switcher which is a bug.
awesome, will make the library switcher padding a separate thing