spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-141] Add Tooltips

Open spacedrive-bot opened this issue 2 years ago • 4 comments

I tried adding react-tooltip, but it doesn't work. That is all. Working branch attached. Jamie Pine on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

@haris Problem here is when you include the tooltip on the page, you have to rebuild every time dynamic props change and re-render the component. You can either do this far up in the tree by doing the following:

useEffect(() => {
  ReactTooltip.rebuild();
});

or you can add this within whatever component you're using and add the dynamic data variable to the useEffect's dependency array. Benjamin Akar on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

I've somewhat fixed this, however you have to include the ReactTooltip component in whatever component you want to use it in. It also can go under other components and etc, if someone smart with UI and react could take a look at this then I think this could be fixed relatively quick. cc: @haden @benja Haris on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

Looks like the sync system added the comments backwards, need to fix that soon. Anyways, if anyone wants to take a shot at this, this issue is up for grabs. Haris on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

Is this issue expected to be resolved by PR #314 ?

bytrangle avatar Aug 18 '22 16:08 bytrangle

Yep

oscartbeaumont avatar Aug 30 '22 13:08 oscartbeaumont