spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-288] Media data extraction

Open brxken128 opened this issue 2 years ago • 2 comments

brxken128 avatar Jul 14 '23 11:07 brxken128

ENG-288 Media data

Metadata should be extracted from all media Objects, saved in the media_data table.

Currently we have a media_data.rs file, but it is using ffmpeg-next. It would be better to get this moved to the ffmpeg crate. I'm not sure if ffmpeg-next is redundant in the presence of ffmpeg-next-sys but they look drastically different.

The current implementation is tacked onto the thumbnail generation, but it could be its own job. It also crashes when uncommented because of a unique constraint. Weird given it is an upsert.

linear[bot] avatar Jul 14 '23 11:07 linear[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 4:31pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 4:31pm

vercel[bot] avatar Jul 14 '23 11:07 vercel[bot]

Reverting to draft again as it turns out there's a LOT more we can improve upon to ensure coverage for the most amount of images.

brxken128 avatar Jul 16 '23 10:07 brxken128

It worked, until I merged main and @Brendonovich's sync stuff completely broke it. I'm unsure where to go from here.

brxken128 avatar Jul 26 '23 18:07 brxken128

Converting to a draft once again as we need to integrate the MediaDataImage struct (and the nested structs) within the frontend, but I'm not too sure how.

brxken128 avatar Jul 29 '23 00:07 brxken128

let's fix types and merge this pls

utkubakir avatar Aug 29 '23 10:08 utkubakir

This should be ready to go, there's no/minimal UI work but that can come in another PR as this one is quite large already.

brxken128 avatar Aug 29 '23 14:08 brxken128