spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-767, ENG-916] Improvements and fixes for `Open`/`Open With`

Open HeavenVolkoff opened this issue 2 years ago • 3 comments

  • [X] Normalize PATH and XDG envvars on Linux
  • [X] ~Check if desktop entry executable is available to Spacedrive before considering it as a valid handler~
  • [X] Replace custom Desktop file parser and open with code with Gio AppInfo: https://github.com/gtk-rs/gtk-rs-core/tree/master/gio https://docs.gtk.org/gio/iface.AppInfo.html https://gitlab.gnome.org/GNOME/gtk/-/blob/main/tools/gtk-launch.c
  • [X] Fix AppImage env influencing external apps launched through Spacedrive
  • [X] Normalize GStreamer plugin environment path list
  • [X] Implement Open With fallback logic for macOS < 12
  • [X] Replace opener with GLib API for opening files and directories in Linux

Closes #1013 Resolves ENG-767, ENG-916

HeavenVolkoff avatar Jul 07 '23 04:07 HeavenVolkoff

ENG-767 "Open", "Open With" and "Open in file manager" don't work correctly on some Linux systems

https://github.com/spacedriveapp/spacedrive/issues/1013

From discord:

BlueskyFR (OP) — Yesterday at 12:56 PM
Sorry for opening multiple questions but I am trying out Spacedrive on Arch Linux so I am trying to provide useful feedback 😉

When opening a pdf file Firefox gets opened so I was wondering: on what do you rely to open files?
When opening the same file with xdg-open, the right app gets opened instead of Firefox for me.

linear[bot] avatar Jul 07 '23 04:07 linear[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 5:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2023 5:32pm

vercel[bot] avatar Jul 07 '23 04:07 vercel[bot]

ENG-916 Implement `Open With` logic compatible with macOS < 12

Currently our native swift code used for the Open With functionality in macOS only works in macOS >= 12 (Sierra). Need to implement a fallback logic that works on macOS >= 10.15 (Catalina), which is our stated minimum supported version

linear[bot] avatar Jul 14 '23 21:07 linear[bot]