spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Fix job resuming/pausing and cancelling

Open utkubakir opened this issue 2 years ago • 1 comments

We don't know why this works, but it does.

utkubakir avatar Jun 27 '23 17:06 utkubakir

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 5:45pm

vercel[bot] avatar Jun 27 '23 17:06 vercel[bot]

I think its because one worker handles all jobs in a group, so to pause a worker you would need to send the id of the first job in the group.

jamiepine avatar Jun 27 '23 19:06 jamiepine

It works because this data.id here https://github.com/spacedriveapp/spacedrive/blob/main/interface/app/%24libraryId/Layout/Sidebar/JobManager/JobGroup.tsx#L83 is the job group id, not the individual job's id. This was the reason I introduced using the job.parent_id as the worker_id when possible.

fogodev avatar Jun 27 '23 22:06 fogodev