spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

Landing page errors in Brave browser

Open McPizza0 opened this issue 1 year ago • 6 comments

Describe the bug

https://www.spacedrive.com/ does not open or work in brave browser image

note: if brave shields are disabled, site renders correctly

Reproduction

  1. Install Brave
  2. Go to https://www.spacedrive.com/
  3. Page flash, then error

Expected behavior

For the site to render correctly

Platform and versions

Not relevant

Stack trace

No response

Additional context

Brave is not reporting any detected items to block But disabling shields renders the page correctly image

McPizza0 avatar Jun 26 '23 08:06 McPizza0

Are you sure this isn't more to do with your device? I use Brave and the site loads fine. image image

Brendonovich avatar Jun 26 '23 12:06 Brendonovich

@Brendonovich When changing Block fingerprinting from Aggressively block fingerprinting (default) to just block fingerprinting (as per your screenshot) - site renders correctly

McPizza0 avatar Jun 26 '23 12:06 McPizza0

That does break things, but Block Fingerprinting seems to be the default for me (I've never changed it). Brave's settings do warn that aggressive blocking can break sites, but it would be nice to know why it breaks + if it's possible to fix. image

Taking a look at console logs it seems like WebGL stuff is failing to load, perhaps we rely on some external scripts that are being blocked? image image

Brendonovich avatar Jun 26 '23 12:06 Brendonovich

I dont remember changing mine either 🤔 First time I've had this kind of issue.

Agree it would be good to fix "just in case"

McPizza0 avatar Jun 26 '23 12:06 McPizza0

Also experience this, on LibreWolf (WebGL disabled by default): image

This is most likely related to the recent changes made in #966. We should probably be doing some graceful error handling and just fall backing to the old background when WebGL is not available

HeavenVolkoff avatar Jun 26 '23 15:06 HeavenVolkoff

Apparently Brave blocks some WebGL features in aggressive blocking mode so that would make sense

Brendonovich avatar Jun 26 '23 15:06 Brendonovich

Librewolf was fixed, but Brave still needs a bit more work as it doesn't actually disable WebGL, but most of the API returns invalid values on the Aggressively block fingerprinting mode

HeavenVolkoff avatar Jul 06 '23 02:07 HeavenVolkoff