spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

replace github star button in home cta component

Open YounesBessa opened this issue 2 years ago • 13 comments

YounesBessa avatar Jun 23 '23 11:06 YounesBessa

@YounesBessa is attempting to deploy a commit to the Spacedrive Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 23 '23 11:06 vercel[bot]

We use a custom button since it matches our theme - not sure this would be a good fit

Brendonovich avatar Jun 23 '23 15:06 Brendonovich

Oh okay I thought that's what Jamie wanted, he mentioned it on stream earlier today

YounesBessa avatar Jun 23 '23 15:06 YounesBessa

Ah, didn't catch that. Will leave it to him to review then

Brendonovich avatar Jun 23 '23 15:06 Brendonovich

Requiring an internet connection for a button to load doesn't sit right with me on an offline first desktop application.

oscartbeaumont avatar Jun 23 '23 15:06 oscartbeaumont

That's just on the landing page of the website, isn't it?

YounesBessa avatar Jun 23 '23 16:06 YounesBessa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ❌ Failed (Inspect) Mar 19, 2024 3:17pm
spacedrive-web 🔄 Building (Inspect) Mar 19, 2024 3:17pm

vercel[bot] avatar Jun 23 '23 16:06 vercel[bot]

Great PR, thank you for your contribution. Can we make the GitHub button or our waitlist button the same height? Can we also make it dark?

utkubakir avatar Jun 23 '23 16:06 utkubakir

As far as I know you can't make it dark but the width and height are adjustable, should I shrink the Github button or make the waitlist button bigger?

YounesBessa avatar Jun 23 '23 16:06 YounesBessa

Yes, the width and height are adjustable, should I shrink the Github button or make the waitlist button bigger?

Let's shrink the Github button, also instead of the middle. Can we put it to the top right and to the footer? Because we will replace the current buttons with download links soon.

utkubakir avatar Jun 23 '23 16:06 utkubakir

Op sorry I was thinking about putting this in the footer like cal.com do.

jamiepine avatar Jun 27 '23 19:06 jamiepine

Okay I just reverted that first commit and put the button in the footer instead

YounesBessa avatar Jun 27 '23 20:06 YounesBessa

image

The location of it is great, but it's a big boi that's for sure haha @jamiepine

utkubakir avatar Jun 30 '23 15:06 utkubakir