Jonny Harris

Results 160 comments of Jonny Harris

@swissspidy Any word on this PR? It has been blocked for 2 weeks awaiting feedback.

Example code. In uninstall.php ``` PluginFactory::create()->on_plugin_uninstall(); ``` in Taxonomy_Base ``` public function on_plugin_uninstall() { clean_taxonomy_cache( $this->taxonomy_slug ); $term_query = new WP_Term_Query(); $terms = $term_query->query( [ 'taxonomy' => $this->taxonomy_slug, 'hide_empty' =>...

Examples of data found in the REST API for media. We have some of this data, - File size - bit rate - dimensions - video length - Audio codex...

> Right now the check is just looking at the element.resource to decide when it recommends to optimize the video, however what's unintuitive is how the properties are set on...

In my discovery for this ticket I found [Yoast WooCommerce SEO plugin](https://yoast.com/wordpress/plugins/yoast-woocommerce-seo/). I wonder if need to do testing against this plugin or intergration points etc.

Is the plan here to just copy and paste the `get_product_data` method. This maybe hard, as how this is setup, we don't really have access to `Discovery`. If we change...

Right, what I am trying to avoid here, is having hard code the post meta and basically copy and paste the logic from our plugin to there. Which is what...

> So get_products() would just return the list of products without formatting. I like that idea! I would look something like this. ``` $story = new Story(); $story->load_from_post( $presentation->model->object_id );...

I put together a [POC](https://github.com/GoogleForCreators/web-stories-wp/tree/try/product-data) move the get_products method into story model. I like it, it is clean. One thing, we are going to have to do a check for...

Should we also look at adding video data? See #12221