Jonny Harris

Results 160 comments of Jonny Harris

@swissspidy I am seeing blurhash and base color generating twice on every upload now. Sadly, I can't think of way around this, as the second is done after inserting in...

So just an update here. I did some playing around with this. I basically adding some state, to add an array of new resources added and then when the dialog...

@swissspidy I think I have found a solution to this problem using a ref. See https://github.com/GoogleForCreators/web-stories-wp/pull/11941/commits/2d34582d4b0140d9cdf1ea4fab1c1750101b4d81. Take a look at the commit and see what I am doing here.

@swissspidy That is happening in last commit. The instance of wp.media in now stored / cached in a ref. This means, that a new instance is not created on every...

@swissspidy @timarney is one of you going to take this PR on? Or will wait until I get back. I think it is close to mergable but I haven't got...

This PR is now out of date. Closing and re-openning if I have a better idea.

Is this possible with ffmpeg.wasm? I can't see options in the docs for this. I may have missed it.

To confirm, we mean, cropping the image or cropping the video length? Or both?

Reopening as this ticket now valid again. When filtering, uploaded media is lost. See video. https://user-images.githubusercontent.com/237508/179958667-0df3c40f-76f5-412e-90b9-bd13848ec247.mov The issue is this line https://github.com/GoogleForCreators/web-stories-wp/blob/77bc376ee9e406bf69e9534fc9d2b72617ae0b48/packages/story-editor/src/app/media/local/reducers/setMediaType.js#L27 Sadly this was missed as part of https://github.com/GoogleForCreators/web-stories-wp/pull/9785....

I have put together a POC for a fix for this issue. https://github.com/GoogleForCreators/web-stories-wp/compare/try/fix-processing-item?expand=1 Basically, add a new processing piece of state, that is a backup for processing items. It even...