Jonny Harris

Results 160 comments of Jonny Harris

> So basically doing that at a higher level (before the preload) vs. within the controller? Yeah, I would have done it in [edit-story.php](https://github.com/GoogleForCreators/web-stories-wp/blob/main/includes/templates/admin/edit-story.php).

I played around with generating a poster image here. https://github.com/GoogleForCreators/web-stories-wp/blob/3a05d3346e3f945c8a4e4dfdcfb94ea07637a31e/packages/story-editor/src/app/media/utils/useProcessMedia.js#L533-L537 Generate a poster file and blob and set it here. We maybe about to generate a cropped poster image by...

Related: https://github.com/GoogleForCreators/web-stories-wp/issues/8715

https://user-images.githubusercontent.com/237508/190669367-63f01ae0-d529-4205-9101-b43943e60be1.mov As you can see in the video, why the video is processing, the video poster does not represent what the user see on the canvas. It does correct itself...

> video/poster in the media library On canvas is look correct. But in the media library is does look incorrect.

Sadly I think we are going to have to use ffmpeg to generate the poster image. Until the video is done processing, we can't use the existing video / canavas...

I had a play around with this. I am not sure the best way forward. I could not get the canvas to work, as I dont understand how the params...

Also see - https://core.trac.wordpress.org/changeset/52700

https://make.wordpress.org/core/2022/04/29/caching-improvements-in-wordpress-6-0/

https://make.wordpress.org/core/2022/04/29/caching-improvements-in-wordpress-6-0/