spr icon indicating copy to clipboard operation
spr copied to clipboard

[docs] Need clarification on how to insert a commit into the middle of an ongoing stacked PR review

Open koachan opened this issue 1 year ago • 0 comments

Say I have a commit history that looks like this:

xxxxxx Commit A
yyyyyy Commit B

Then I submit them for review with spr diff --all. However, during the review it become clear that I should make another commit ("Commit C") inbetween A and B. So my goal is to change the commit history into something like this:

xxxxxx Commit A
zzzzzz Commit C
yyyyyy Commit B

How do I do this? Would inserting the new commit with git rebase -i then rerunning spr diff --all works, or do I need to do other things to achieve that?

koachan avatar Jun 22 '24 04:06 koachan