sxt-proof-of-sql icon indicating copy to clipboard operation
sxt-proof-of-sql copied to clipboard

Published 20 hours ago • verified publisher icon spaceandtimelabs

Make Scalar conversions explicit

Open maujim opened this issue 3 months ago • 2 comments

Please go through the following checklist

  • [x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular ! is used if and only if at least one breaking change has been introduced.
  • [ ] I have run the ci check script with source scripts/run_ci_checks.sh.

Rationale for this change

  • this is step 1 of 3 for #228, each step will ideally be a standalone PR
  • /claim #228

What changes are included in this PR?

Copied from description of #228

  • Remove Into<[u64; 4]>, From<[u64; 4]>, and RefInto<[u64; 4]> bounds.
  • Replace these with the trait methods fn from_limbs(val: [u64; 4]) -> Self and fn to_limbs(&self) -> [u64; 4]

Are these changes tested?

Not yet, thats why its in draft

maujim avatar Nov 04 '24 14:11 maujim