sxt-proof-of-sql icon indicating copy to clipboard operation
sxt-proof-of-sql copied to clipboard

missing ge, eq, ineq postprocessing implementations for TimeStampTZ

Open Dustin-Ray opened this issue 5 months ago • 2 comments

Here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/6740144a5d3d01583d264d2560e68ff5f0025b22/crates/proof-of-sql/src/base/database/owned_column_operation.rs#L182

Here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/6740144a5d3d01583d264d2560e68ff5f0025b22/crates/proof-of-sql/src/base/database/owned_column_operation.rs#L316

And Here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/6740144a5d3d01583d264d2560e68ff5f0025b22/crates/proof-of-sql/src/base/database/owned_column_operation.rs#L450

@iajoiner I must have forgotten about these when we wrapped up timestamp, sorry about that. What are the above lines used for? Because right now, full provable inequality is supported on timestamp-related queries:

"SELECT * FROM table WHERE times > timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times < timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times >= timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times <= timestamp '1970-01-01T00:00:00Z';",
"SELECT * FROM table WHERE times = timestamp '1970-01-01T00:00:00Z';",

All succeed without incident. Should I fill out these missing implementations marked as todo!()?

Dustin-Ray avatar Sep 12 '24 00:09 Dustin-Ray