space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Fix ERT becoming sleeper agents and add sleeper agent preferences

Open Dutch-VanDerLinde opened this issue 1 year ago • 11 comments

Why / Balance

people might wanna be roundstart syndie but not syndie 5 seconds until evac docks ERT sleepers are bad

Technical details

adds AntagImmune comp and blacklists it from traitor and zombies removes inital infected exempt renames the event from SleeperAgentsRule to SleeperAgents

Media

image

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

:cl:

  • tweak: Syndicate sleeper agents are now opt-in. You can opt-in with the antagonist preferences menu.
  • fix: ERT are no longer able to become sleeper agents.

Dutch-VanDerLinde avatar May 08 '24 21:05 Dutch-VanDerLinde

adds a mindshield blacklist for traitor selection

Does mindshield implant null all future syndicate contracts or its specific for initial command/sec shielding?

thebadman4662 avatar May 08 '24 21:05 thebadman4662

adds a mindshield blacklist for traitor selection

Does mindshield implant null all future syndicate contracts or its specific for initial command/sec shielding?

if you get mindshielded as an active syndie nothing happens, it only blacklists you from becoming a syndie

Dutch-VanDerLinde avatar May 08 '24 21:05 Dutch-VanDerLinde

meaning new sec strat: mindshield criminals to prevent them from becoming sleeper agents :trollface:

Dutch-VanDerLinde avatar May 08 '24 21:05 Dutch-VanDerLinde

While this PR is nice i think making mindshields stop being sleeper agents kinda goes a bit far, the rest is cool tho

yeah on second glance i don't really get the mindshield thing. that's not really the behavior we had before and its not like getting mindshielded un-syndies you. I mostly construe mindshields to be protection from actual psychological threats like brainwashing and possession and cultists and whatnot, not something as grounded as being a spy.

EmoGarbage404 avatar May 15 '24 00:05 EmoGarbage404

yeah on second glance i don't really get the mindshield thing. that's not really the behavior we had before and its not like getting mindshielded un-syndies you. I mostly construe mindshields to be protection from actual psychological threats like brainwashing and possession and cultists and whatnot, not something as grounded as being a spy.

the intent is just so ERT can't roll sleeper, but im not sure what component to use for them should i just make like a TraitorImmune component like inital infected?

Dutch-VanDerLinde avatar May 15 '24 01:05 Dutch-VanDerLinde

the intent is just so ERT can't roll sleeper, but im not sure what component to use for them should i just make like a TraitorImmune component like inital infected?

might be worth having a generic AntagImmune component akin to how we have it for jobs. I imagine things like ERT should never be antags to begin with so it'd be good to have.

EmoGarbage404 avatar May 15 '24 03:05 EmoGarbage404

If that's done should probably replace InitialInfectedExempt then? Not sure if there's a reason to have that and AntagImmune (especially since ZombieImmune also exists).

Vermidia avatar May 15 '24 03:05 Vermidia

If that's done should probably replace InitialInfectedExempt then? Not sure if there's a reason to have that and AntagImmune (especially since ZombieImmune also exists).

yes

Dutch-VanDerLinde avatar May 15 '24 03:05 Dutch-VanDerLinde

the intent is just so ERT can't roll sleeper, but im not sure what component to use for them should i just make like a TraitorImmune component like inital infected?

might be worth having a generic AntagImmune component akin to how we have it for jobs. I imagine things like ERT should never be antags to begin with so it'd be good to have.

done

Dutch-VanDerLinde avatar May 16 '24 13:05 Dutch-VanDerLinde

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 01 '24 05:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 04 '24 00:06 github-actions[bot]