Ninja's pinpointer tracks the research server

[nikthechampiongr]

About the PR

This pr has the pinpointer of the ninja track the research server instead of BecomesStation.

Why / Balance

I will admit this fix is as much of a hack as what it fixes. Basically, in order to track the station the ninja's pinpointer tries to track a grid with the BecomesStation component. The problem is, apparently every grid gets that when it's saved. This includes randomly spawned wreckage. This leads to the ninja tracking random wreckage in space.

So why ResearchServer? Well we can be sure that any station which intends to have a playable science department(Hopefully every station) will have an RD server and wrecks do not. Its destruction is unbelievably rare, and it's loosely aligned with the ninja's objective to steal research.

I would have used the CommsConsole component instead since they can be expected to be on the station and there are multiple of them making it less likely that the ninja's pinpointer will point to nothing. Unfortunately that component is on admin ghosts. As such it would allow ninjas to track admins which while funny, should not happen.

Alternative solutions:

• Have a special case for the pinpointer component where it will try to find the station instead of relying on a component.
• Rewrite the pinpointer system so that instead of you giving it a component, stuff can have something like "PinpointerTrackableComponent" which would allow the ninja system to just add it to the active station when a ninja spawns.
• Have some marker component added to a grid when the station gets initialized. From what I understand this would go against the design of the current station system where there is no singular grid that is TheStationTM

Technical details

Media

• [x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

• fix: Ninjas will no longer be pointed to random wreckage in space.

[Cojoke-dot]

This can cause an issue of salv gets a server, but is still quite a good idea

[Dutch-VanDerLinde]

This can cause an issue of salv gets a server, but is still quite a good idea

if salv gets a server the ninja can just take the salv shuttle to the station

[deltanedas]

powergaming salv makes server and throws it into space to fuck ninjas over:

[Cojoke-dot]

This can cause an issue of salv gets a server, but is still quite a good idea

if salv gets a server the ninja can just take the salv shuttle to the station

Yes, I had that thought. The biggest issue with that is that it's practically forcing you to reveal yourself to get on station. Either way salv does not commonly pick up servers... so meh, it's just me pointing out something I saw

[Dutch-VanDerLinde]

powergaming salv makes server and throws it into space to fuck ninjas over:

rolebanned