space-station-14
space-station-14 copied to clipboard
space-wizards
Already constructed gas filter instructs me on how to construct it
Description
When I construct a flipped gas filter with 2 steel, it already works just fine, but tells me how to construct it. Apparently I need to unwrench it?
Reproduction
- Construct a flipped gas filter.
- Examine it.
- Get confused.
Screenshots
Additional context I am not being dumb in atmos, am I? I know I am pretty novice, but this just does not feel right.
It looks like the this bug was introduced together with the ability to flip construction ghosts during construction 3f93b11e4acb9af9468bf1111cbbcade0a459f59.
The after placing the flipped filter constuction ghost, and constructing it into an actual flipped filter, the inspection of ConstuctionComponent shows that constructed object is in filter node like it would be regular filter, but the target node is still filterflipped.
Looking at the constructionSystem I found out that at https://github.com/space-wizards/space-station-14/blob/99130ff332913c03924560ac497386d9d40857d5/Content.Server/Construction/ConstructionSystem.Initial.cs#L274 the newly created ConstructionComponent already has wrong Node value.
OK, the prototype just inherits whatever ConstructionComponent the normal filter had, with the Node set to filter. Overriding Node of ConstructionComponent in GasFilterFlipped should fix it.
