space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Make suit storage only available for hardsuits, softsuits, and armor

Open notquitehadouken opened this issue 1 year ago • 11 comments

About the PR

Made using suit storage require a hardsuit or softsuit to be equipped, instead of just any outerclothing.

Why / Balance

So that you cannot put air tanks or weapons into suit storage while wearing just a winter coat or poncho

Technical details

Adds the AllowSuitStorage component, which is given to all hardsuits and softsuits

Adds the DependsOnComponents field to inventory slot definitions, which specifies a list of components the entity in the item slot given by the DependsOn field must have in order to it to be usable

Media

  • [ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

  • tweak: You can now only use suit storage with hardsuits, softsuits, and armor instead of all outer clothing

notquitehadouken avatar Apr 30 '24 19:04 notquitehadouken

that slot is not only for tanks and not being able to wear a gun in that slot does not make much sense. I often see handguns placed in that slot, like the captain's pistol. I like to put my emergency o2 tank there so I activate it quickly as a secoff for smoke nades. I can totally see restricting tanks to only suits, but not weapons.

Cojoke-dot avatar Apr 30 '24 19:04 Cojoke-dot

I use that slot for my disabler, I use it for my sidearm pistol as warden. I use that slot during combat for my rifle. I use that slot as a poor musician for my spear as I run from zombies.

That slot is used for allot of stuff, I don't see any reason for this change and it will only hamper current gameplay. Even restriction of air tanks to hard/soft suits seems un-needed. Unrealistic maybe, but we have space clowns, we shall survive.

Hanzdegloker avatar Apr 30 '24 19:04 Hanzdegloker

Me when content from ss13 is ported incorrectly and then people get mad when its fixed.

If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

EmoGarbage404 avatar Apr 30 '24 19:04 EmoGarbage404

Me when content from ss13 is ported incorrectly and then people get mad when its fixed.

If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

I'm fairly certain this was brought up before and it was intended to allow usage of the exoslot beyond void suits.

LordEclipse avatar Apr 30 '24 19:04 LordEclipse

Me when content from ss13 is ported incorrectly and then people get mad when its fixed. If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

I'm fairly certain this was brought up before and it was intended to allow usage of the exoslot beyond void suits.

Correction: Suit Storage/Exo Slot whitelist. Like being able to store a gun in armor but not lab coats, or large oxy tanks on hardsuits but not jackets. Far more interesting option as otherwise this just blindly encourages people to wear voidsuits more than they already do.

LordEclipse avatar Apr 30 '24 20:04 LordEclipse

Yeah I think stuff like letting guns be held in armor is fine. It may be ported “incorrectly” from 13, but also this is a different games and features can be changed if people like it better.

LankLTE avatar Apr 30 '24 20:04 LankLTE

fine i'll give armor the component (security buff in disguise)

notquitehadouken avatar Apr 30 '24 21:04 notquitehadouken

can you add a summary description to the component?

Plykiya avatar Apr 30 '24 23:04 Plykiya

I still don't see the point in beating around the bush. We should just make it a backslot that can't hold a backpack and call it a day.

IProduceWidgets avatar May 01 '24 02:05 IProduceWidgets

Me when content from ss13 is ported incorrectly and then people get mad when its fixed.

If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

This wasn't the case in SS13, you could store emergency oxygen tanks in hazard vests and winter coats. Likewise armour could store weapons like stun batons, disablers, etc. as others pointed out.

I think LordEclispes' proposal for a storage whitelist depending on the type of suit would best replicate this behaviour (and work well for gameplay).

Lamrr avatar May 01 '24 02:05 Lamrr

does this remove inventory from coats and aprons and such?

Hmeister-real avatar May 01 '24 08:05 Hmeister-real

I see the logic behind this change but nobody asked for this and it will just make the game more unfun tbh

Thurtik avatar May 02 '24 19:05 Thurtik

This just makes it more clunky to handle makeshift weapons incase of nukies or whatever. Majority of departments had outerclothing or had ways to obtain it easily and it seems pretty unintuitive that some clothing allows weapons and others don't even though they would need straps to be worn like that in real life.

Doctor-Cpu avatar May 02 '24 19:05 Doctor-Cpu

it gets funnier the more dislikes it has

notquitehadouken avatar May 10 '24 21:05 notquitehadouken

Me when content from ss13 is ported incorrectly and then people get mad when its fixed. If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

And yet this is still ported incorrectly in this pr so it's not wrong to be upset that it's imported incorrectly again in a worse way, no?

Here's a winter coat in ss13, as other people have already mentioned holding the emergency tank in the suit storage. Suit storage uses a whitelist on items per clothing, not disabling the entire function if you're not wearing a hardsuit.

If you're going to double down and say suit storage should only be for suits in 14, don't use ss13 as an excuse and then imply people are mad because it was imported incorrectly.

image

QuietlyWhisper avatar May 12 '24 10:05 QuietlyWhisper

Me when content from ss13 is ported incorrectly and then people get mad when its fixed.

If you were meant to get extra storage when wearing literally any outclothing, you might as well have a 3rd pocket with a mild whitelist. Its called suit storage for a reason.

it wasnt fixed, the implementation is still incorrect, but in a way that actively makes the experience worse than both the first failed implementation and the SS13 Intended implementation

Djungelskog2 avatar May 12 '24 11:05 Djungelskog2

I mean, personally i like it the “wrong way” so its not the whole playerbase

UbaserB avatar May 12 '24 11:05 UbaserB

This should apply only to air tanks. In a good way, a weapon should not require outerwear at all, it has a strap on all sprites.

Welldzhik avatar May 15 '24 18:05 Welldzhik