space-station-14
space-station-14 copied to clipboard
Nature of emergency for calling the shuttle on the communications console
About the PR
the call shuttle button on the communications console opens a textbox which allows you to enter the nature of emergency
Why / Balance
now command can give a reason easily as to why they're calling the shuttle 5 minutes in the shift
Technical details
Media
https://github.com/space-wizards/space-station-14/assets/45323883/b514d300-7ecc-4066-bcad-9a15143caa0c
- [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Breaking changes
none
Changelog :cl:
- tweak: The communications console now allows you to enter a nature of emergency for calling the emergency shuttle.
Should force them to write a few characters before allowing to call like ss13
Should force them to write a few characters before allowing to call like ss13
did it
should it not just re-use the existing Announcement text...
multiline edit?
just dont see why it has to pop up a new window
also no reason this couldnt use quick dialog thing
I'm not sure if using the same box is very intuitive. You have the text field followed by two buttons that do use its contents (Announce and Broadcast), followed by a button that doesn't use it (the alert level), followed by a label then finally, followed by the call shuttle button which does use the contents again. At least initially people might get caught out that calling the shuttle uses that text.
Maybe it would be clearer as; Announce Broadcast Shuttle Label Alert
So all the buttons that use the field are grouped together.
I'm not sure if using the same box is very intuitive. You have the text field followed by two buttons that do use its contents (Announce and Broadcast), followed by a button that doesn't use it (the alert level), followed by a label then finally, followed by the call shuttle button which does use the contents again. At least initially people might get caught out that calling the shuttle uses that text.
Maybe it would be clearer as;
Announce
Broadcast
Shuttle
Label
Alert
So all the buttons that use the field are grouped together.
I agree it's why I had it as the pop up before
Maybe the the announce and the call shuttle buttons could be next to eachother under the text box and then have the other options under that with a spacer inbetween.
also no reason this couldnt use quick dialog thing
uses this now
I agree with mirror that it should just re-use the existing multiline edit for the announcement text. That's already how people tend to use it currently: sending an announcement conventionally then pressing the button. You could do the same with alert levels too. Additionally, second dialogue window is very clunky and isn't suited to long amounts of text.
As a final note, i'd opt to remove the "nature of emergency" header from the announcement text and instead just opt to put the message directly there, as long as there is one.
I agree with mirror that it should just re-use the existing multiline edit for the announcement text. That's already how people tend to use it currently: sending an announcement conventionally then pressing the button. You could do the same with alert levels too. Additionally, second dialogue window is very clunky and isn't suited to long amounts of text.
As a final note, i'd opt to remove the "nature of emergency" header from the announcement text and instead just opt to put the message directly there, as long as there is one.
So, would it appear like this:
"The emergency shuttle has been called. ETA: 10 minutes. [reason]"?
agreed with emo
Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.