Add standard, wallmount and improvised N2 closets

[Lamrr]

About the PR

Adds standard, wallmount, and improvised versions of the N2 emergency closets. Resolves #27194 Existing N2 lockers on maps are migrated to their equivalent improvised N2 lockers.

Why / Balance

There are now corresponding N2 emergency closets to all O2 ones, I believe this is part of having other species breathe N2? An improvised N2 closet, consisting of a sign taped onto a fire closet, has been preserved to reflect N2's relative undersupply and the fact that NT probably doesn't care too much about its non-O2 crew. There is no wallmount equivalent of this because I imagine making a wallmount locker requires such an effort you may as well use a for-purpose closet.

Technical details

A few notes for cartographers, since N2 is relatively underused I'd recommend just slapping down one or two improvised N2 lockers on your map and call it day. For nicer places where NT might advertise its DEI credentials (like Centcom!) perhaps use the normal N2 lockers.

Media

Standard variants on the left, improvised on the right

• [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

RSI Diff Bot; head commit 861ce069c6c7fcf3580a9c1f66b1e6b0bb318efb merging into 18fa8bf633c73b7d0914194a4ddd5fed1cf93f0c This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/closet.rsi

State	Old	New	Status
n2_door			Modified
n2_door_improvised			Added

Resources/Textures/Structures/Storage/wall_locker.rsi

State	Old	New	Status
n2			Added
n2_door			Added
n2_open			Added

Edit: diff updated after 861ce069c6c7fcf3580a9c1f66b1e6b0bb318efb

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Lamrr]

A few thoughts:

1. Explicitly state that the fancy N2 closets aren't for station-side use in the suffix, with something like "DO NOT MAP STATION-SIDE," "Fancy," or "Centcomm" or whatever. People will probably map them anyways if you don't do this.

2. There needs to be a wallmount version of the shitty N2 ones, or else people will map the fancy ones alongside the shitty ones, which we don't want. Make sure the sprite is based off of the fire locker one, to maintain consistency!

3. This isn't really that important, but the current locker probably shouldn't be referred to as "improvised" in the prototype name, I feel like that implies that it's craftable, or non-standard. I would suggest referring to the new one as "fancy" or "full" or something, and leaving the old one as-is.

I think cartographers should be able to choose which one they want to use, depending on how 'nice' they think their station is. I do agree that they should be pointed towards the 'improvised' ones more.

So how about;

improvised emergency n2 closet -> emergency n2 closet emergency n2 closet -> emergency n2 closet [Fancy]

Which would also fix the naming issue.

In regards to a shitty wallmount variant, that just doesn't make much sense to me, there are less (or none) surplus wallmounts. Why would the station drill out another hole in the wall just put the wrong type of closet in? Either they'd use a cheap repurposed closet or a expensive proper wall mount, but they would not use the still expensive yet still improvised wall mount.

[EmoGarbage404]

your branch is cooked

[Lamrr]

your branch is cooked

Yes, sorry everyone who got pinged by this. I have messed up somewhere with git...

edit 28/04:

Okay I've fixed the issues with the branch now. All the changes here actually relate to the PR now. Sorry about the confusion

[Emisse]

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

[SonicHDC]

@Lamrr maybe time to reopen PR? Now we have voxes #29704