space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Published 20 hours ago • verified publisher icon space-wizards

Adds wielding for all large guns

Open RiceMar1244 opened this issue 10 months ago • 13 comments

About the PR

This PR makes basically all large, feasibly two-handed guns able to be wielded, and have default accuracy while doing so. If not wielded, guns will now be somewhat inaccurate.

Why / Balance

I made this change because I had a lot of fun spriting the wield sprite for the PKA, and it got me thinking about the other guns. I enjoy the commitment in putting all hands on a weapon, with all the limitations that brings. I feel like this change will bring interesting new design motivations when considering a new class of weapons that require two hands.

It is worth noting that this PR does not actually make any balance decisions, and currently each of the wieldable guns suffer the same inaccuracy when not wielded and have default accuracy, as they did before, when wielded.

Technical details

It's all yml

Media

https://youtu.be/qZgc4l9TWW4

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Nothing breaks, but its worth mentioning that the shotguns are do not currently suffer an inaccuracy penalty when unwielded because for some reason minangle and maxangle on the gun component is not actually affecting the angle of the shot. I was thinking about making them require wielding to compensate but I wanted to leave it consistent until advised otherwise.

Changelog

:cl: RiceMar

  • add: Larger guns are wieldable now and suffer an inaccuracy when not wielded.

RiceMar1244 avatar Apr 15 '24 03:04 RiceMar1244

RSI Diff Bot; head commit 8a6b56b79f69fd35db165cbd51f22df82f82246f merging into a4ab997f1f829099bba8aae844fa95259dac2f6f This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Battery/laser_cannon.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Battery/laser_gun.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Battery/pulse_carbine.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Battery/pulse_rifle.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Battery/xray.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Launchers/china_lake.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Rifles/ak.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/SMGs/c20r.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/blunderbuss.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/bulldog.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/db_shotgun_inhands_64x.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/enforcer_inhands_64x.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/improvised_shotgun_inhands_64x.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Shotguns/pump_inhands_64x.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Snipers/bolt_gun_wood.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Resources/Textures/Objects/Weapons/Guns/Snipers/heavy_sniper.rsi

State Old New Status
wielded-inhand-left Added
wielded-inhand-right Added
Edit: diff updated after 8a6b56b79f69fd35db165cbd51f22df82f82246f

github-actions[bot] avatar Apr 15 '24 03:04 github-actions[bot]

Just FYI you aren't supposed to make IC changelogs! Link to the PR guidelines

beck-thompson avatar Apr 15 '24 03:04 beck-thompson

I always found it weird that, oh no you must wield a mop to get your full damage use outta it, nobody can onehand a mop and get full use

but guns like shotguns we just one hand like its nobody's business, bout time we start wielding our bloody guns

Hanzdegloker avatar Apr 15 '24 03:04 Hanzdegloker

Just FYI you aren't supposed to make IC changelogs! Link to the PR guidelines

Ah, lemme read this guideline again. Last I was aware, slightly-humorously-immersive changelogs were allowed.

RiceMar1244 avatar Apr 15 '24 03:04 RiceMar1244

For some reason most of the textures make my brain think that you're holding a fish...

What advantage is presented for wielding most of these weapons? If you have a lake you want your other hand for reloading and it's quite accurate for the massive aoe it has. What does wielding a shotgun do? I don't think I have seen a shotgun be inaccurate to the point that it affects anything. Also 100% accuracy for the lecter? That... that feels like its going to cause some kind of issue...

Cojoke-dot avatar Apr 15 '24 07:04 Cojoke-dot

What does wielding a shotgun do? I don't think I have seen a shotgun be inaccurate to the point that it affects anything.

when med refactors a thing, shooting shotguns one handed should hopefully be able to break your hand, or before that at least launch the shotgun out of your hand when you try shooting it

Hmeister-real avatar Apr 15 '24 09:04 Hmeister-real

Add Drozd

SoulFN avatar Apr 15 '24 09:04 SoulFN

To my knowledge, most guns did not have any specified inaccuracy before I made these changes. I will double check again and make sure that I am not disrupting balance.

RiceMar1244 avatar Apr 15 '24 15:04 RiceMar1244

I havent added Drozd personally because its shape made it difficult to sprite, but i still believe that it would be appropriate if it were wieldable. So sure I can add it, and if I cant figure out a good looking wield sprite Ill just let it have default inhand or something

RiceMar1244 avatar Apr 15 '24 17:04 RiceMar1244

I have added the drozd and bulldog to the wieldable guns

RiceMar1244 avatar Apr 15 '24 20:04 RiceMar1244

merg?

Hmeister-real avatar Apr 22 '24 09:04 Hmeister-real

A new note for clarity, the nukie c20r is not yet wieldable and I don't have an asset for it yet.

RiceMar1244 avatar Apr 23 '24 19:04 RiceMar1244

Hey there, my fix for not being able to cycle wielded guns has been merged and you should be able to apply it to all guns. Its just a variable for Wieldable that enables unwielding on use, so it's easy to turn off.

- type: Wieldable
  unwieldOnUse: false

Defaults shouldn't be applied en masse like that.

metalgearsloth avatar Apr 27 '24 05:04 metalgearsloth

RPG over the shoulder wielding? please? 🥺

ps3moira avatar May 09 '24 21:05 ps3moira

Huzzah!!

RiceMar1244 avatar May 10 '24 02:05 RiceMar1244