space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Add Botany Garden Gnomes Ghost Role

Open PaigeMaeForrest opened this issue 10 months ago • 19 comments

About the PR

This PR adds the Gnome ghost role to botany!

Gnome features

They are a ghost role For early to late round use, they have the following abilities and traits:

  • A hand slot to pick up items
  • they can drag items for storage (such as a survival box or backpack)
  • they can be picked up and worn as hats and die when thrown
  • they are healed and revived with glue bottles
  • Gnomes are grown from a Gnome hat that can be planted into a gnome plant that grows the gnome
  • they are very fragile (10 health) but dont need air and are resistant to tempature damage
  • being hollow they are weak to pressure changes that cause them to break quickly, space is an instant death.
  • can be gibbed into a gnome hat and glass
  • has a gnome accent that replaces no at the start of words to GNO and certain past tence words to GNOMED eg: killed > GNOMED (The captain is GNOMED)
  • weak to blunt, slightly resistant to slash and peircing, and very resistant to burns
  • rooms can be "Gnome proofed" with mouse traps
  • Gnomes act like a normal garden gnome untill possesed by a ghost player
  • Healing a gnome uses 5u of glue

the design doc PR is located here: https://github.com/space-wizards/docs/pull/208

Why / Balance

This adds to content to botany and adds to the variety of ghost roles players can have. One day someone asked me to add gnomes, I figured it would be fun to do so and fun to have more ghost role variety. my ramblings about gnomes and Gnomevelopment are at the Gnomvelopment development thread in the ss14 discord. the many abilities gnomes have, (being small, going under doors, not needing air, having hands.) are negated by being very easy to kill, and if they are a repeat offender, gib. additionaly they are somewhat rare maintnece loot keeping their numbers small and rare.

Technical details

Adds gnomes, the gnome hat, and the plant that spawns them. this also adds a tag for plants that should not be clipped (this is only applied to the gnome plant), along with that it adds a gnome accent.

known problems:

  • items look kinda weird when they are holding them -(FIXED GLUE IS NOW USED WHEN HEALING WOOOO)

Media

Screenshot 2024-04-13 184659 Screenshot 2024-04-13 184652 Screenshot 2024-04-13 184643 Screenshot 2024-04-13 184543

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

Hopefully no breaking changes. Changelog

:cl: BITTERLYNX

  • add: Gnome hats have been found in select maint lockers. Gnome hats can be grown into full Gnomes to help botany in gardening and/or theft

PaigeMaeForrest avatar Apr 14 '24 02:04 PaigeMaeForrest

RSI Diff Bot; head commit 8ec1a6b0eacbe153b9cf6f3ebf625be55782bf18 merging into d85d9fbbd1f3073ad91f5db215bb659a8184b539 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Hats/hat_gnome.rsi

State Old New Status
equipped-HELMET Added
icon Added
Resources/Textures/Mobs/Animals/gnome.rsi

State Old New Status
0-equipped-HELMET Added
1-equipped-HELMET Added
Gnome-0 Added
Gnome-1 Added
dead-1 Added
Resources/Textures/Objects/Specific/Hydroponics/gnome.rsi

State Old New Status
dead Added
harvest Added
stage-1 Added
stage-2 Added
Edit: diff updated after 8ec1a6b0eacbe153b9cf6f3ebf625be55782bf18

github-actions[bot] avatar Apr 14 '24 02:04 github-actions[bot]

Is there a doc for this

metalgearsloth avatar Apr 14 '24 02:04 metalgearsloth

Time to lookie at the checks :3

PaigeMaeForrest avatar Apr 14 '24 02:04 PaigeMaeForrest

yes there is a doc, but it has not yet been merged

PaigeMaeForrest avatar Apr 14 '24 02:04 PaigeMaeForrest

Haha I love this 😆

beck-thompson avatar Apr 14 '24 02:04 beck-thompson

Im taking this pr out of draft and into open so i can have the checks run, the Design doc is still not merged and should probably be merged before this is considered for merging

PaigeMaeForrest avatar Apr 15 '24 02:04 PaigeMaeForrest

Somebody else suggested it but it would be really funny if gnomes seeds were mutated carrot seeds.

KingOnBudget avatar Apr 15 '24 08:04 KingOnBudget

Somebody else suggested it but it would be really funny if gnomes seeds were mutated carrot seeds.

I tried coding that but with how botany code is written I'd have to do a lot of work just for this case or mutating from carrots would create 3 gnomes every time (mutating to a different plant keeps the yield of the old plant unfortunately) if botany is refactored or I get smarter I'd love to add that (Also in the morning I gotta make sure I removed the carrot mutation bc if not it's gonna be buggy as hell)

PaigeMaeForrest avatar Apr 15 '24 08:04 PaigeMaeForrest

I checked now, I did NOT change that and also I forgot to clean up the repairable file I gotta do that tomorrow

PaigeMaeForrest avatar Apr 15 '24 08:04 PaigeMaeForrest

I tried coding that but with how botany code is written I'd have to do a lot of work just for this case or mutating from carrots would create 3 gnomes every time (mutating to a different plant keeps the yield of the old plant unfortunately) if botany is refactored or I get smarter I'd love to add that (Also in the morning I gotta make sure I removed the carrot mutation bc if not it's gonna be buggy as hell)

Idk maybe that's fine, it's fine for the killer tomatoes pr at least (similar principle of seeds creating mobs)

K-Dynamic avatar Apr 15 '24 08:04 K-Dynamic

I tried coding that but with how botany code is written I'd have to do a lot of work just for this case or mutating from carrots would create 3 gnomes every time (mutating to a different plant keeps the yield of the old plant unfortunately) if botany is refactored or I get smarter I'd love to add that (Also in the morning I gotta make sure I removed the carrot mutation bc if not it's gonna be buggy as hell)

Idk maybe that's fine, it's fine for the killer tomatoes pr at least (similar principle of seeds creating mobs)

yeah, i figured i would make the spawn rate ultra low to start and i can always try and add it in the future if its not too much of a problem

PaigeMaeForrest avatar Apr 15 '24 17:04 PaigeMaeForrest

The gnome accent should replace words beginning with "no" rather than "g" since "gnomes" is said with an "n" sound.

So for example, instead of "Let's gno", "I love "gnrowing plants", which is basically unreadable and confusing, it should replace stuff like so:

  • "I'm gnot interested"
  • "I love egg gnogg"
  • "Let's gnot be hasty"
  • "I he broke my gnose!"
  • "He's not gnormal in the head"
  • "I didn't do gnothing!"
  • "That's gnonsense!"

It's more readable, thematic, and funny imo.

Stokes52 avatar Apr 18 '24 14:04 Stokes52

The gnome accent should replace words beginning with "no" rather than "g" since "gnomes" is said with an "n" sound.

So for example, instead of "Let's gno", "I love "gnrowing plants", which is basically unreadable and confusing, it should replace stuff like so:

  • "I'm gnot interested"
  • "I love egg gnogg"
  • "Let's gnot be hasty"
  • "I he broke my gnose!"
  • "He's not gnormal in the head"
  • "I didn't do gnothing!"
  • "That's gnonsense!"

It's more readable, thematic, and funny imo.

Aye ill role out that change once I got a moment Thanks for the suggestion because gno required a weird pronunciation to sound decent

PaigeMaeForrest avatar Apr 18 '24 20:04 PaigeMaeForrest

I need evil gnome ghost roles for the Floral anom.

FungiFellow avatar Apr 24 '24 16:04 FungiFellow

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 27 '24 10:04 github-actions[bot]

if i understand this correctly i just have to move the glue tool tag thingy to alphabetcal and that fixes the conflict (i think) i no longer fear the conflicts tag >:3 THE CHECKS BE A FAILING NOOOOOOOOOOOO

edit: i have no idea what im looking at i hope i didnt feck up this time

PaigeMaeForrest avatar Apr 27 '24 15:04 PaigeMaeForrest

dispite what the commit is labeled that code is indeed finished and works properly

PaigeMaeForrest avatar Apr 27 '24 21:04 PaigeMaeForrest

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 28 '24 11:04 github-actions[bot]

unfortunately i need to go back into the botany code mines, ill do it later im giving up on gnomes for now

PaigeMaeForrest avatar Apr 30 '24 03:04 PaigeMaeForrest

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

Emisse avatar May 10 '24 16:05 Emisse