space-station-14
space-station-14 copied to clipboard
space-wizards
Medical Borg QoL
About the PR
-Added health analyzer to treatment module -Added advanced topicals to advanced treatment module -Gave medical cyborgs a medical HUD overlay
Why / Balance
-Basic borg treatment module is hamstrung by the lack of a health analyzer. Effective treatment requires a third party to tell the borg the type of damage before beginning treatment. -Advanced treatment module should have advanced topicals to match features of the basic treatment module. -Medical borg -> Medical HUD. If doctors can get them round-start, the dedicated medical borgs should come with it.
Technical details
Mainly YAML changes adding components to relevant prototypes. 1 variable change to HandsContainer code. MaxButtonsPerRow from 6 -> 10. Original value impacted UI of new advanced treatment module which had 7 items displayed as 6 + 1 left aligned in a row above. No impact outside of borgs (unless you add something with >10 hand slots).
Media
- [X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Breaking changes
N/A Changelog
:cl:
- add: Cyborg treatment module now includes a health analyzer
- add: Cyborg advanced treatment module now includes slots for sutures and meshes
- add: Medical cyborgs now come equipped with a medical HUD
is this still being worked on??? if it hasn't then it's been done for ages so just merge it already!!!!
is this still being worked on??? if it hasn't then it's been done for ages so just merge it already!!!!
No one likes a whiner please be patient champ.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can I get some clarification on what you mean by "generic healer" then? Generic as in "can hold multiple item types" or "is an all-in-one topical" or something else? Given the items by design need to be lingering & non-removable, I'm struggling to see what your intent is.
It's the same problem as borg construction where, instead of implementing a constructor or cleaner system, it instead gets 5+ dummy entities trying to workaround code limitations instead of fixing the underlying code limitation.
If someone decides borgs need to be able to heal 4 different damage types there's now 4 bloat entities for no other reason than not wanting to do it well.
Ok, I see where you're coming from. I'll admit though, I'm not skilled enough to tackle the task of "rewrite borg shit-code". I am still of the opinion that medical borgs should have access to the same topicals that humans do, but if its going to block this PR than I'll just pull it out for now. I'm tired of this PR being in limbo
a shame we aren't getting borg with medhud any time soon
Ok so like.... I understand your desire, and I'm equally frustrated that this PR hasn't been a quick open/close. But come on man, that's just needlessly passive aggressive. You basically just insulted the bouncer while trying to get into a bar.
It's the same problem as borg construction where, instead of implementing a constructor or cleaner system, it instead gets 5+ dummy entities trying to workaround code limitations instead of fixing the underlying code limitation.
Long-term / from a design perspective, what are your thoughts on an RCD-like or omnitool-like device to meet that requirement? I say RCD as a reference point since any "generic" solution for topicals MUST have some recurring resource cost for use as a way of balancing it. Otherwise it would make medical borgs the objective "best" option for all scenarios. Have the module slowly generate the resource at the cost of energy up to a maximum and have advanced topicals cost more of said resource?
The omnitool angle is the ability to cycle through different options within the tool. New RCD interface seems like it would be a nicer UI/UX feel though.
Thanks for all your work on this btw MjrLandWhale, really looking forward to this being implemented.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This still getting done? Mediborg still in need of basic analyzer. 😔
No. You'll have more luck making the PR for it yourself or getting someone like AJCM to do it.
I can make a or tonight when I get home. Just adding a line if it's just the borg module, right?
Yeah. You can also remove the dropper to prevent hand bloat, since it serves no purpose