space-station-14
space-station-14 copied to clipboard
Add prediction to Spill Container verb, add dummy TrySpill methods to shared
About the PR
The verbs menu entry for Spill Container is now added in Shared, so it will show up when generating the verbs menu client-side, without having to wait for the server to send it.
Why / Balance
Waiting for all the verbs to show up in the menu is annoying, and it's a real pain when the menu jumps around after getting more verbs from the server. This is one less verb that will do that.
Technical details
All of the TrySpillAt and TrySplashAt methods in Server's PuddleSystem were made into overrides of new abstract versions in SharedPuddleSystem, and Client was given dummy implementations that always fail. Proper prediction for those methods would require spawning client-side entities, then replacing them with the server-side entities when the update arrives, which would be a great system to have but not something happening right now. Having the ability to call these methods (and do nothing client-side) from Shared is helpful though - in this case for the spill DoAfter, but I've run into other instances where I want to have it. PreventSpillerComponent was moved to Shared.
Media
- [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Breaking changes
PreventSpillerComponent was moved to Shared, which will affect any using directives that reference it.
Changelog
Nope
This pull request has conflicts, please resolve those before we can evaluate the pull request.