space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

The detective can bug rooms

Open IProduceWidgets opened this issue 1 year ago • 17 comments

About the PR

Adds 2 sets of discrete listening devices for the detective to use, given he manages to get access to a communications server, hopefully legally through the warrant of a command staff member.

image

To preempt the question: It does not give enough keys to make them useful as headset keys, except for listening to the bugs. One of the two available keys must be in a communications server to function.

Be careful not to lose your toys though! An unsuspecting janitor might just throw them away...

Why / Balance

Its funny, mostly.

Technical details

Media

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

  • add: The detective has discrete listening devices! To use add one key to a headset and the other to a communications server!

IProduceWidgets avatar Feb 06 '24 19:02 IProduceWidgets

RSI Diff Bot; head commit ca466e7c03ab5176b1fcb1fb7ed50894349279f5 merging into 046d062230ccbc841f969b25f2182c7415e99253 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Devices/communication.rsi

State Old New Status
bug Added
Edit: diff updated after ca466e7c03ab5176b1fcb1fb7ed50894349279f5

github-actions[bot] avatar Feb 06 '24 19:02 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 06 '24 19:02 github-actions[bot]

Just a note: I could make the frequencies not require a communications server, but that seems meh, and Ideally Id rather some form of limit to them. I leave the decision on whether the det gets his own server to mappers, since any server will do he can always ask the HoP etc for access to set it up.

IProduceWidgets avatar Feb 06 '24 20:02 IProduceWidgets

what

lzk228 avatar Feb 06 '24 22:02 lzk228

Isn't a tape recorder better

metalgearsloth avatar Feb 06 '24 22:02 metalgearsloth

Isn't a tape recorder better

I think theyre just different? Unless you want to make an always active tape recorder. Heck you could even just make a tape recorder that could listen to a radio channel and then record this (or general / syndicate / etc) radio. I leave the prospect of wire taps for the future though.

IProduceWidgets avatar Feb 07 '24 02:02 IProduceWidgets

This area of the code is a tad spooky and is touched by #24680, as a warning

FairlySadPanda avatar Feb 07 '24 15:02 FairlySadPanda

Maybe detective should get their own little server with space for 2 keys in it, that we can add to maps in detectives office. Would probably be better solution than detective having to beg to have them put in a telecoms server.

brainfood1183 avatar Feb 07 '24 16:02 brainfood1183

Maybe detective should get their own little server with space for 2 keys in it, that we can add to maps in detectives office. Would probably be better solution than detective having to beg to have them put in a telecoms server.

Maybe. Don't want to make any mapping changes in the same PR though.

IProduceWidgets avatar Feb 07 '24 18:02 IProduceWidgets

This area of the code is a tad spooky and is touched by #24680, as a warning

I skimmed the changes in your PR, and I think they probably wont interfere with eachother too much since this uses the standard radio functionality. I can always update it later if changes are needed.

I would have liked to have some functionality from #21546 and #21513 but theyre not strictly necessary, so much as they just clean up some of the yml messiness.

IProduceWidgets avatar Feb 07 '24 18:02 IProduceWidgets

Another options I suppose is to give the det a communications server board, and its a build your own adventure. I sorta like the idea of the detective having to ask for a warrant or permission though.

IProduceWidgets avatar Feb 07 '24 18:02 IProduceWidgets

The recorder and the wiretapping bug have completely different applications, I don't think they can be compared. I think this is a useful mechanic for tracking suspicious people. Can a bug be hung on a person or his clothes?

Nimfar11 avatar Feb 08 '24 07:02 Nimfar11

Another options I suppose is to give the det a communications server board, and its a build your own adventure. I sorta like the idea of the detective having to ask for a warrant or permission though.

Telecom boards are surprisingly hard to come by and locked behind research (but strangely they only need 2 steel and 3 lv cable to complete, excluding machine frame assembly)

K-Dynamic avatar Feb 08 '24 10:02 K-Dynamic

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 17 '24 20:02 github-actions[bot]

As per pr guidelines for changelogs 4. You should avoid "IC" speak. Specifically "Maybe the hop will let them be used"

VasilisThePikachu avatar Mar 03 '24 02:03 VasilisThePikachu

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 27 '24 13:04 github-actions[bot]

@IProduceWidgets see review

metalgearsloth avatar Apr 28 '24 09:04 metalgearsloth

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

Emisse avatar May 10 '24 15:05 Emisse