space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Add wearable body cameras

Open Rainfey opened this issue 1 year ago • 26 comments

About the PR

Added body wearable cameras

Why / Balance

Seemed like a good idea, allows command to monitor individual crew or to monitor in progress operations without putting themselves in danger Also - crew entertainment

Technical details

Cameras are equippable to the neck slot. The cameras broadcast on the Wireless device net, on the Security subnet. This necessitates as Wireless Camera Router [Security] be mapped OR built by the crew Each body camera otherwise operates the same as a news camera. Cameras are automatically activated when equipped, and deactivated when unequipped ( i feel small spy cameras to be a bit unbalanced, so they only work when equipped) They can be constructed at the Security Techfab for 1 Steel, 1 Glass and 2 Plastic.

Alternatives to the above aproach have their own drawbacks:

  1. Bodycams could be added to the Wired device net, this will give them unlimited range and prevent audio (Camera Monitor does not output audio from what i can see)
  2. Bodycams could be added to a new device net, which will require a new computer/device to receive and display the feed.

Media

Camera when worn Screenshot 2023-11-26 214138

Camera on the ground (crowbar for scale) Screenshot 2023-11-26 214025

Video of usage

https://github.com/space-wizards/space-station-14/assets/11758391/b1aea924-e569-41ca-8cf2-3d05fcca4fc4

  • [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog :cl:

  • add: Wearable Bodycameras

Rainfey avatar Nov 25 '23 01:11 Rainfey

RSI Diff Bot; head commit 5e445b611c6237807b014c5b3a95ef7e37c4b654 merging into 8bb07df2cb46dd62971a3a0bdf71f1253b230fb5 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Neck/Misc/bodycamera.rsi

State Old New Status
equipped-NECK Added
icon Added
Edit: diff updated after 5e445b611c6237807b014c5b3a95ef7e37c4b654

github-actions[bot] avatar Nov 25 '23 01:11 github-actions[bot]

Now we need the ability to record and replay

Brandon-Huu avatar Nov 25 '23 01:11 Brandon-Huu

i was trying to add some previously in #17324 but the issue is cameras don't use energy, what looks kinda OP

lzk228 avatar Nov 25 '23 03:11 lzk228

I feel like the sprite should be improved, right now it looks like it doesnt fit the style of the game for some reason

UbaserB avatar Nov 25 '23 04:11 UbaserB

I make no claims of being any good with artwork - consider them placeholders. Regarding battery power, this seems reasonable - if its deemed necessary then i shall add it in.

Rainfey avatar Nov 25 '23 05:11 Rainfey

I make no claims of being any good with artwork - consider them placeholders. Regarding battery power, this seems reasonable - if its deemed necessary then i shall add it in.

i mean if you want i can try sprite it

UbaserB avatar Nov 25 '23 05:11 UbaserB

should have an implant version

Ilya246 avatar Nov 25 '23 06:11 Ilya246

If this is added, first off it is way too high quality to be fair, why do reporters need to lug around big cameras when security has the same thing. It would be better if the cameras where intentionally delayed and had some grainy filter, maybe also don't transmit sound just video. Also they should probably be more zoomed in, so that you can't see 360 around the person wearing it. Other than that, cool PR.

Hmeister-fake avatar Nov 25 '23 09:11 Hmeister-fake

If this is added, first off it is way too high quality to be fair, why do reporters need to lug around big cameras when security has the same thing. It would be better if the cameras where intentionally delayed and had some grainy filter, maybe also don't transmit sound just video. Also they should probably be more zoomed in, so that you can't see 360 around the person wearing it. Other than that, cool PR.

Or just make reporter's cameras better.

IamVelcroboy avatar Nov 25 '23 13:11 IamVelcroboy

I dont think there is a way to reduce the visible FOV on a camera, its always 360. But i think i can zoom it in. I can also reduce the wireless range, currently they work within a range of 200 (tiles?) from the camera router - meaning there would be deadzones. Same goes for the microphone, can reduce the range on that.

Rainfey avatar Nov 25 '23 17:11 Rainfey

Added battery slot and usage, calibrated for 10 minutes per small cell Added popup text when activating/deactivating the camera Camera can be toggled when worn, without holding in your hand Reduced audio pickup range to 5 rather than 10 Fixed license on texture

Question: Do i need an 'ActiveBodyCameraComponent' like the radio jammer? Not sure if there was a reason a new component was used versus an Enabled bool.

Rainfey avatar Nov 25 '23 19:11 Rainfey

https://github.com/new-frontiers-14/frontier-station-14/pull/312

Seem about like what I did, only thing you might want to change is require it to be equipped to work as people will just hide them around if not.

dvir001 avatar Nov 25 '23 19:11 dvir001

Had a look over your PR dvir001, some nice ideas.

  • Cameras are auto enabled when equipped, and disabled when unequipped - preventing them from working in bags or pockets. (Also means you cant leave the camera on the floor as a spy camera, perhaps this is a good idea but i think it would be a little overpowered to throw cameras into cargo 'just in case' there are Rev's)
  • Cameras now set their name based upon your ID, had to touch SurveillanceCameraSystem for this - added a public method for changing names.
  • Removed the UI from the camera, since names are auto set.

Rainfey avatar Nov 26 '23 02:11 Rainfey

Im not sure if i can move BodyCameraSystem into Content.Shared, it uses SurveillanceCameraSystem which only exists in Content.Server. SharedSurveillanceCameraSystem.cs does exist, but it does not appear to contain any classes - just two enums.

Documentation first pass, is more detail or additional documentation required? Now using PowerCellDraw. Now using file-scoped namespaces

Rainfey avatar Nov 26 '23 04:11 Rainfey

Half a year ago I made bodycam sprites for one of Chief_Engineer's prototype uploads if this may interest you, otherwise (YES!!) finally bodycams (epic)

equipped-NECK icon3

Skarletto avatar Nov 26 '23 16:11 Skarletto

Do you have a license you would prefer the sprites be added under?

Rainfey avatar Nov 26 '23 20:11 Rainfey

Just standard CC-BY-SA 3.0

Skarletto avatar Nov 26 '23 21:11 Skarletto

I would suggest making the camera's view range a lot smaller. Bit weird it has such a large range being so small.

ps3moira avatar Dec 08 '23 05:12 ps3moira

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 21 '23 17:12 github-actions[bot]

in fact, every morning I wake up crying and hope this pr becomes merged

icekot8 avatar Jan 23 '24 06:01 icekot8

Dont know if it ever will, it seems it may cause performance issues - or atleast contribute to them. I'll keep it maintained and mergeable for now.

Rainfey avatar Jan 23 '24 10:01 Rainfey

I'll keep it maintained and mergeable for now.

You don't need to resolve merge conflicts until after a PR is approved as it'll just waste time.

metalgearsloth avatar Jan 28 '24 00:01 metalgearsloth

@Rainfey are you coming back to this?

AJCM-git avatar Feb 18 '24 21:02 AJCM-git

Indeed i am, once time permits. Work priorities have cut into my available free time.

Rainfey avatar Feb 18 '24 22:02 Rainfey

Drafting as the suggested changes are extensive.

Rainfey avatar Mar 03 '24 07:03 Rainfey

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 27 '24 10:04 github-actions[bot]

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.

Emisse avatar May 10 '24 15:05 Emisse

Just realized this would be awesome if there was an alternative sprite for a hand-held live camera for news reporters!

ps3moira avatar Jun 13 '24 20:06 ps3moira

This would be an actual fucking godsend for upcoming AI, keep this alive.

GroggleG avatar Jun 13 '24 20:06 GroggleG