space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Dump orebag into ore processor

Open Jackrost opened this issue 2 years ago • 2 comments

About the PR

Orebag can now be used on ore processor to dump content into it. It's use modified code of DumpableSystem and have same cons:

  1. LeftClick to ore processor to dump content into it.
  2. Use verb from context menu as alternative

TryInsertMaterialEntity was little modified to be able turn off popup message to remove message spam from every single insert of ore.

P.S. You can add popup for DisposalUnit later if you willing to do so.
Screenshots

Changelog

:cl:

  • add: you can now dump collected ore into ore processor with orebag

Jackrost avatar Oct 16 '22 11:10 Jackrost

This also allows to dump something into every entity that have MaterialStorageComponent but only if used object have DumpableComponent

Jackrost avatar Oct 16 '22 12:10 Jackrost

You can try to dump trash to ore process and action bar will appear with followed popup message after completion, but whitelist don't allow to insert trash into ore processor. So is it really matter?

Jackrost avatar Oct 16 '22 12:10 Jackrost

For some reason Ore Bag don't have TagComponent even when it's use tags in whitelist while Ore Processor have TagComponent. So, I code simple check without it.

Jackrost avatar Oct 20 '22 19:10 Jackrost

For some reason Ore Bag don't have TagComponent even when it's use tags in whitelist while Ore Processor have TagComponent. So, I code simple check without it.

The bag doesnt have any tags. The tags for the ore processor are for the types of materials that can be inserted.

EmoGarbage404 avatar Oct 20 '22 19:10 EmoGarbage404

For some reason Ore Bag don't have TagComponent even when it's use tags in whitelist while Ore Processor have TagComponent. So, I code simple check without it.

The bag doesnt have any tags. The tags for the ore processor are for the types of materials that can be inserted.

It's have image

Jackrost avatar Oct 20 '22 20:10 Jackrost

shoveling coal into the ore processor manually is a rite of passage

mirrorcult avatar Oct 22 '22 22:10 mirrorcult

@Jackrost are you coming back to this.

metalgearsloth avatar Nov 15 '22 08:11 metalgearsloth

@Jackrost are you coming back to this.

Yes, but I need some help with whitelist

Jackrost avatar Nov 15 '22 13:11 Jackrost

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 18 '22 21:12 github-actions[bot]

Re-open when ready

metalgearsloth avatar Jan 10 '23 13:01 metalgearsloth