space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Published 20 hours ago • verified publisher icon space-wizards

Adds an alarm for when the AME runs out of fuel

Open Zymem opened this issue 2 years ago • 3 comments

About the PR

Changelog

:cl: Zyme

  • add: The AME will now warn you when it runs out of fuel

Zymem avatar Oct 15 '22 21:10 Zymem

RSI Diff Bot; head commit 65606e0984f0ed300d7ea11e56f1daa9ed4d10c6 merging into 33c14562236ff00bd4ca7af722675064e565e63e This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Power/Generation/ame.rsi

State Old New Status
control_fuelless Added
Edit: diff updated after 65606e0984f0ed300d7ea11e56f1daa9ed4d10c6

github-actions[bot] avatar Oct 15 '22 22:10 github-actions[bot]

Apparently there was an error on the tests when setting up .NET Core, more specifically when reading ECONNRESET... Gotta be honest, I have no idea what any of that means, so any help would be appreciated.

Edit: it works now ¯\(ツ)/¯

Zymem avatar Oct 16 '22 01:10 Zymem

This should preferably be ECSed also (all logic moved from component to system)

0x6273 avatar Oct 16 '22 12:10 0x6273

I guess practicing C# PRs with old code probably wasn't the best idea, especially for learning ECS lmao. I won't be having that much free time for the next couple of weeks, so I doubt I'll be trying to update the code to modern standards (also waay beyond my current scope).

I'll leave it up to the mantainers if they want to merge this PR, or prefer closing it until #11967 is solved.

Zymem avatar Oct 16 '22 23:10 Zymem

Alright, thanks for the review. I'll probably just close the PR seeing as seeing as 0x6273 seems to be working on updating the AME code. If this isn't included in the refractor I'll try to see of adding it then.

Zymem avatar Oct 22 '22 00:10 Zymem