space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Published 20 hours ago • verified publisher icon space-wizards

Oldchat

Open vulppine opened this issue 1 year ago • 1 comments

About the PR

SS13 style chat. This is still being worked on, and will have screenshots posted later when it's in a more complete state.

Changelog

:cl:

  • add: The classic Space Station 13 style HUD layout has been ported to Space Station 14! Enjoy having your chat in its own separate section of game HUD!

vulppine avatar Oct 14 '22 08:10 vulppine

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 16 '22 15:10 github-actions[bot]

I really think that the top bar of buttons should be reversed, so that Esc is next to the top right corner instead of just kind of in the middle of the screen. Otherwise, incredibly based.

ike709 avatar Oct 17 '22 19:10 ike709

NRE when opening client

[FATL] unhandled: System.NullReferenceException: Object reference not set to an instance of an object.
   at Robust.Shared.GameObjects.EntitySystemManager.GetEntitySystem[T]() in K:\github.com\mirrorcult\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystemManager.cs:line 65
   at Robust.Shared.GameObjects.EntitySystem.Get[T]() in K:\github.com\mirrorcult\space-station-14\RobustToolbox\Robust.Shared\GameObjects\EntitySystem.cs:line 143
   at Content.Client.UserInterface.Systems.Chat.Widgets.ChatBox.OnTextChanged(LineEditEventArgs args) in K:\github.com\mirrorcult\space-station-14\Content.Client\UserInterface\Systems\Chat\Widgets\ChatBox.xaml.cs:line 200

mirrorcult avatar Oct 17 '22 21:10 mirrorcult

(on startup, i hadn't typed anything)

mirrorcult avatar Oct 17 '22 21:10 mirrorcult

ok that might be a master bug actually (edit it was)

mirrorcult avatar Oct 17 '22 21:10 mirrorcult

ok that might be a master bug actually (edit it was)

i moved that system get into the controller anyways since there's already a dependency for it

vulppine avatar Oct 17 '22 21:10 vulppine

I really think that the top bar of buttons should be reversed, so that Esc is next to the top right corner instead of just kind of in the middle of the screen. Otherwise, incredibly based.

the layout of the menu bar buttons isn't dynamic and would require another separate widget to be implemented in order to achieve this (not necessarily a bad idea, still)

vulppine avatar Oct 17 '22 21:10 vulppine

i agree w ike on the order of the buttons but doesnt need to be done in this PR imo

mirrorcult avatar Oct 17 '22 21:10 mirrorcult