space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Add announcement wrap to department radio messages for non-player sources (salvage magnet)

Open HoofedEar opened this issue 2 years ago • 3 comments

About the PR

The salvage magnet no longer "says" anything. This PR provides a way to define a radio message as an announcement, so that the message is a lot cleaner looking over the radio. This also accounts for the requested change in #10001 (if-else)

Screenshots

image

Changelog

:cl:

  • tweak: Salvage magnet can no longer speak

HoofedEar avatar Oct 14 '22 04:10 HoofedEar

Maybe instead of flat out removing the "says", how about use "beeps" instead?

Just-a-Unity-Dev avatar Oct 14 '22 04:10 Just-a-Unity-Dev

Maybe instead of flat out removing the "says", how about use "beeps" instead?

Even with "beeps" it still looks a bit messy since it would say "Salvage magnet beeps:" so it would be named Salvage magnet which is very odd and confusing. Maybe if the magnet was possessed by a player? But this is just to non-sentient interactions

HoofedEar avatar Oct 14 '22 22:10 HoofedEar

I'm currently scrapping IListen and IRadio, which will probably conflict with this pretty heavily.

ElectroJr avatar Oct 16 '22 19:10 ElectroJr

Marked as draft until #11980 is complete. Changes should be easy enough

HoofedEar avatar Oct 17 '22 16:10 HoofedEar

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 18 '22 07:10 github-actions[bot]

Gonna remake this after Crimbo

HoofedEar avatar Dec 22 '22 21:12 HoofedEar