space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Reduce frequency of extended rounds

Open GoodWheatley opened this issue 2 years ago • 6 comments

About the PR

This might be a controversial PR and I understand if it gets rejected, but right now I feel like extended shows up way too much in rounds. The whole novelty of the gamemode in SS13 was that it was a rare break from the chaos that happens every round, but it shows up so often that it just devolves into selfantag shittery once nothing exciting happens. This change isn't intended to be permament, mostly just a bandaid fix until mirror adds that Survival mode he's working on.

Screenshots

Changelog

:cl:

  • add: Extended is now less likely to appear as a gamemode.

GoodWheatley avatar Oct 13 '22 14:10 GoodWheatley

Accidentally was merging my master branch with that last pr, sorry

GoodWheatley avatar Oct 13 '22 14:10 GoodWheatley

If this is to reduce the frequency of extended on mid-low pop secret Salamander rounds, how about making Secret reroll instead of the "Failed to start gamemode!" message?

Just-a-Unity-Dev avatar Oct 13 '22 15:10 Just-a-Unity-Dev

If this is to reduce the frequency of extended on mid-low pop secret Salamander rounds, how about making Secret reroll instead of the "Failed to start gamemode!" message?

I was thinking more of the LRP shitters who start selfantagging when they realize its Extended, but I can see if I can do this with another PR

GoodWheatley avatar Oct 13 '22 16:10 GoodWheatley

If this is to reduce the frequency of extended on mid-low pop secret Salamander rounds, how about making Secret reroll instead of the "Failed to start gamemode!" message?

Also, if I just forced a reroll again, wouldn't that mean it would be possible to create an infinite reroll loop if there isn't enough players for any gamemode?

GoodWheatley avatar Oct 13 '22 16:10 GoodWheatley

this will be unnecessary with #11362

mirrorcult avatar Oct 14 '22 19:10 mirrorcult

If this is to reduce the frequency of extended on mid-low pop secret Salamander rounds, how about making Secret reroll instead of the "Failed to start gamemode!" message?

Also, if I just forced a reroll again, wouldn't that mean it would be possible to create an infinite reroll loop if there isn't enough players for any gamemode?

Maybe pick from a list of gamemodes, pop one, if it's too much then pop again? Not sure how to explain this but it'd look something like this in Python

modes = ['extended', 'nukeops', 'traitor', 'zombies']
selected_mode = None

while selected_mode == None:
  # .pop() removes it from the modes list so it cant be picked again
  chosen_mode = modes[random()].pop()
  if validated(chosen_mode):
    selected_mode = chosen_mode

Just-a-Unity-Dev avatar Oct 15 '22 03:10 Just-a-Unity-Dev