space-station-14 icon indicating copy to clipboard operation
space-station-14 copied to clipboard

Published 20 hours ago • verified publisher icon space-wizards

Additional examine details

Open rolfero opened this issue 2 years ago • 3 comments

About the PR

This does several things (that perhaps should've been split up into several PRs, not sure).

  1. First, it adds ExamineGroups as an easier way to show entity examine details. Instead of having a separate examine tooltip button for each component or set of details that should be examinable (for example, currently there is one button to examine clothing speed modifiers and a separate button for the armor values), these details can now be grouped into ExamineGroups. All components instead feed their examine details into a specific examine group which sorts the information, which is presented using a single tooltip button. This way you can bundle together certain details that fit together (for example, atmospherical pressure protection and atmospherical temperature protection) and separate them from other details (such as stat increases/decreases, such as armor values and speed penalties).

  2. Changing the text slightly on armor & speed examine details, to fit better together.

  3. Adding temperature protection examining and pressure protection examining. Gave these components their own system. Also added stamina damage examining and explosion resistance examining.

  4. Bundling together Armor, Explosion resistance & Speed details together, Pressure & Temperature protection details together, and normal damage & stamina damage together. I've made 2 icons for this use - an atmos icon (should resemble a meter on a pipe hopefully) and the magnifying glass icon with a star in the corner, for general details/stats.

Screenshots

details-icons-showcase stats-showcase-armor atmos-stats-showcase stamina-showcase stamina-showcase-cartridge

Changelog

:cl: Rolfero

  • add: You can now examine objects to learn about their Stamina damage, their Temperature & Pressure protection, as well as their Explosion resistance!
  • add: There are new icons for examining item details.

rolfero avatar Sep 28 '22 23:09 rolfero

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 29 '22 05:09 github-actions[bot]

Did you make the svg files? They're not licensed.

I made them, yes

rolfero avatar Oct 10 '22 20:10 rolfero

ExamineGroups seems like a weird construct to build into examine system itself. couldnt you just have an examine verb specifically for each (MeleeExaminable, GunExaminable, StatsExaminable whatever) which then raises its own event for getting all of its requisite info and puts it into one examine button?

mirrorcult avatar Oct 15 '22 21:10 mirrorcult

ExamineGroups seems like a weird construct to build into examine system itself. couldnt you just have an examine verb specifically for each (MeleeExaminable, GunExaminable, StatsExaminable whatever) which then raises its own event for getting all of its requisite info and puts it into one examine button?

Do you mean a new component for each examine verb? MeleeExaminableComponent, etc?

rolfero avatar Oct 18 '22 17:10 rolfero

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 24 '22 08:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 25 '22 00:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 03 '22 12:11 github-actions[bot]