RobustToolbox icon indicating copy to clipboard operation
RobustToolbox copied to clipboard

Introduce a WarningsAsErrors block to Robust.Properties.targets

Open Mervill opened this issue 1 year ago • 2 comments
trafficstars

One way to have fewer warnings is to turn some warnings into errors.

I have one suggestion to start off: CS0105 which is the duplicate using warning. I don't think I care too much about unused usings but duplicate usings should definitely be an error.

It helps take some of the load off of maintainers by turning incidental shit that causes warnings into quick failures. It's not a big ask for either us or downstreams to correct either, so I seems like a no brainer.

Mervill avatar Sep 03 '24 04:09 Mervill

wasnt aware you could do this for individual warnings, good idea imo

mirrorcult avatar Sep 03 '24 04:09 mirrorcult

The duplicate using from content was removed so if the tests are re-run we should be good.

Mervill avatar Sep 03 '24 05:09 Mervill

Could this cause undue problems for downstreams when doing merges?

PJB3005 avatar Apr 02 '25 14:04 PJB3005