ComfyBox icon indicating copy to clipboard operation
ComfyBox copied to clipboard

Branching history view/restore parameters

Open space-nuko opened this issue 2 years ago • 0 comments

2023-06-03 00_18_19-http___localhost_3000_# - Chromium 2023-06-03 18_15_00-http___localhost_3000_# - Chromium

Needs improvements:

  • Performance is bad with lots of nodes
    • Linear view is better served as a virtual list like the normal history pane
    • History tree should be pruned when it gets too large
  • Parameters should be excludable from patch history, but includable in parameter restore, instead of both or none
    • Exclude both: image uploads, gallery view, display-only widgets (width/height preview for scale by modes)
    • Exclude from patch only: seed (randomized every gen, but doesn't make sense to branch off a new history for each seed change)
  • Parameter restore only shows the name of the individual parameter - just TEnc for a single LoRA weight - so it's difficult to associate which grouped parameter changed
    • At least include the names of containers the widget is contained in for better identification
  • Hovering a history node should show the diffs of the parameters in the UI, instead of just highlighting the changed UI elements
    • Also, can't see the highlights if the widget is off-screen
  • Restore parameters patches don't include combo widget parameters for some reason
  • Default workflow needs to be updated to support patch parameter exclusion

space-nuko avatar Jun 05 '23 18:06 space-nuko