flare icon indicating copy to clipboard operation
flare copied to clipboard

Fix Flacky Tests

Open ns-vasilev opened this issue 1 year ago • 6 comments

This issue is meant to be a good first issue to get into coding, and into open source contribution over all, as it will require to touch few existing files, is a small change and is documented extensively. If you are new to coding, I encourage you to try this issue.

Please read our contribution guidelines before picking this up, it will also lead you through the process of setting up the repository.

Feature description Fix the integration test test_thatFlarePurchasesAProductWithCompletion_whenUnkownErrorOccurred so it doesn't flake and the job doesn't fail in GitHub Actions.

ns-vasilev avatar Sep 14 '24 13:09 ns-vasilev

Excited to fix this integration test! Can you assign it to me?

M7md-Ebrahim avatar Oct 17 '24 06:10 M7md-Ebrahim

@M7md-Ebrahim, sure

ns-vasilev avatar Oct 18 '24 03:10 ns-vasilev

@M7md-Ebrahim how's it going? Do you want to continue on this?

ns-vasilev avatar Oct 24 '24 04:10 ns-vasilev

Yes, I’m a bit busy, and I’m not very good at testing. If you don’t mind, I’ll give it another try.

M7md-Ebrahim avatar Oct 25 '24 16:10 M7md-Ebrahim

I’d like to tackle with this issue. is there a dead line? or is this issue already resolved?

mcrkgus avatar Dec 19 '24 07:12 mcrkgus

@mcrkgus, hi! This issue has not been resolved yet, and there is no deadline. Of course, you can tackle it if you wish.

ns-vasilev avatar Dec 19 '24 07:12 ns-vasilev