flare icon indicating copy to clipboard operation
flare copied to clipboard

Update `Transaction` Model

Open ns-vasilev opened this issue 1 year ago • 3 comments

This issue is meant to be a good first issue to get into coding, and into open source contribution over all, as it will require to touch few existing files, is a small change and is documented extensively. If you are new to coding, I encourage you to try this issue.

Please read our contribution guidelines before picking this up, it will also lead you through the process of setting up the repository.

Feature description Update Transaction model by adding the new fields price and currency according to the documentation.

Documentation.

Describe the solution you'd like Extend the IStoreTransaction protocol by adding the new fields and update dependent models.

ns-vasilev avatar Sep 14 '24 13:09 ns-vasilev

can i work on this issue? i am getting started with swift as a new language I would love to understand and solve this issue

Sauhard74 avatar Sep 26 '24 07:09 Sauhard74

@Sauhard74, sure ;) I've assigned this issue to you. If you have any questions, let me know

ns-vasilev avatar Sep 26 '24 13:09 ns-vasilev

@Sauhard74 how's it going? Do you want to continue on this?

ns-vasilev avatar Oct 01 '24 04:10 ns-vasilev

Hello, I’m excited to work on this issue as well as #76. However, I have a question. After adding the properties like this: /// The price of the in-app purchase recorded in the transaction. var price: Double? { get } /// The currency of the product's price. var currency: String? { get } When it comes to updating the dependent models, is it correct to assign values to these properties by defining an SK1StoreProduct within SK1StoreTransaction, as a way to handle the product information?

M7md-Ebrahim avatar Oct 14 '24 16:10 M7md-Ebrahim

@M7md-Ebrahim, hi! You need to update the models according to the documentation and then update the StoreTransaction, SK1StoreTransaction, and SK2StoreTransaction models. If these fields are not available in StoreKit 1, simply return nil values.

ns-vasilev avatar Oct 15 '24 13:10 ns-vasilev

@M7md-Ebrahim, I've assigned this issue to you. If you have any questions, let me know ;)

ns-vasilev avatar Oct 15 '24 13:10 ns-vasilev