optifine icon indicating copy to clipboard operation
optifine copied to clipboard

I cant see item's variants. Please Fix it!!!!!

Open Daenerys34 opened this issue 11 months ago • 10 comments

Axolot's buckets, horns, paintings, rockets are invisible. Nbt Variants are not working help us!

Daenerys34 avatar Jan 12 '25 11:01 Daenerys34

MC version, OF version, resource pack?

sp614x avatar Jan 12 '25 21:01 sp614x

1.21.4 in texture, the new optifine pre 11

Daenerys34 avatar Jan 13 '25 10:01 Daenerys34

What resource pack are you using? If it uses older unsupported features there should be warnings in the error log.

sp614x avatar Feb 02 '25 09:02 sp614x

Mizuno's 16 craft

Daenerys34 avatar Feb 04 '25 12:02 Daenerys34

[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=0
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_0.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=1
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_1.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=2
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_2.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=3
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_3.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=4
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_4.properties

The NBT checks were replaced with component checks in 1.21.4: https://github.com/sp614x/optifine/blob/master/OptiFineDoc/doc/cit_single.properties#L128

sp614x avatar Feb 04 '25 17:02 sp614x

Added backwards compatibility fix for the axolotl variants.

sp614x avatar Feb 04 '25 17:02 sp614x

The Mizuno's CIT pack complains about missing texture references, it has to be updated to 1.21.4:

Missing textures in model minecraft:optifine/cit/spruce_sapling_1#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/cake_0b#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/cake_inner_1, minecraft:textures/atlas/blocks.png:minecraft:block/cake_side_1, minecraft:textures/atlas/blocks.png:minecraft:block/cake_top_1
Missing textures in model minecraft:optifine/cit/flower_pot_0b#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/flower_pot_0a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_0
Missing textures in model minecraft:optifine/cit/cake_0a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/cake_inner_0, minecraft:textures/atlas/blocks.png:minecraft:block/cake_side_0, minecraft:textures/atlas/blocks.png:minecraft:block/cake_top_0
Missing textures in model minecraft:optifine/cit/spruce_sapling_0#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/snow_block_1#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/red_wool_side
Missing textures in model minecraft:optifine/cit/snow_block_1a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/green_wool_side, minecraft:textures/atlas/blocks.png:minecraft:block/red_wool_side
Missing texture references in model minecraft:optifine/cit/water_bottle_2#inventory: particle
Missing texture references in model minecraft:optifine/cit/painting_4c#inventory: particle
Missing texture references in model minecraft:optifine/cit/cauldron_4d#inventory: particle
Missing texture references in model minecraft:optifine/cit/birch_sign_open#inventory: particle
Missing texture references in model minecraft:optifine/cit/milk_bucket_4#inventory: particle
Missing texture references in model minecraft:optifine/cit/torch_1#inventory: particle
Missing texture references in model minecraft:optifine/cit/dark_oak_sign_shepherd#inventory: particle
Missing texture references in model minecraft:optifine/cit/blue_carpet_0a#inventory: particle
Missing texture references in model minecraft:optifine/cit/jungle_sign_library#inventory: particle
Missing texture references in model minecraft:optifine/cit/sugar_5#inventory: particle
Missing texture references in model minecraft:optifine/cit/bamboo_0#inventory: particle
Missing texture references in model minecraft:optifine/cit/spruce_sign_coffee#inventory: particle
Missing texture references in model minecraft:optifine/cit/chest_0#inventory: particle
Missing texture references in model minecraft:optifine/cit/gold_block_1#inventory: particle

sp614x avatar Feb 04 '25 17:02 sp614x

Added backwards compatibility fix for the axolotl variants.

@sp614x This will cause issues with other competing components. nbt.Variant has been split between both minecraft:bucket_entity_data.Variant and minecraft:entity_data.Variant

ZenithRogue avatar Feb 04 '25 19:02 ZenithRogue

Any components can be added to any item as well, so adding backwards compatibility can have unintended consequences. Skipping most backwards compatibility fixes would be optimal/preferred

ZenithRogue avatar Feb 04 '25 20:02 ZenithRogue

Axolot Buckets are working now! Paintings, Fireworks, Ominous Bottles, Spawn Eggs still Not :/

Daenerys34 avatar Feb 12 '25 06:02 Daenerys34