optifine icon indicating copy to clipboard operation
optifine copied to clipboard

Sky colormap not working properly for the pale garden biome

Open Emfire12345 opened this issue 1 year ago • 14 comments

Using Optifine 1.21.3_HD_U_J2_pre11

When using grid colormaps for the sky and appling a gray color to the pale garden biome (id=65) the sky isnt colored gray but instead deep turquoise but when i try to counteract the color (using a stronger color) the color is applied properly, in short, i cant get the sky to not look bad.

Color example 1: 1 In game 1: 2024-12-01_17 21 07

Color example 2: 2 In game 2: 2024-12-01_17 29 30

Emfire12345 avatar Dec 01 '24 16:12 Emfire12345

Can confirm in 1.21.4pre1. It's worth noting that the transition is also messed up. It fades into an incorrect orangish color when entering the biome, and then after it fully fades it switches to the green color in the above screenshots. Also to the OP: pale garden is ID 12, not 65.

SeaOfPixels avatar Dec 04 '24 02:12 SeaOfPixels

Can confirm in 1.21.4pre1. It's worth noting that the transition is also messed up. It fades into an incorrect orangish color when entering the biome, and then after it fully fades it switches to the green color in the above screenshots. Also to the OP: pale garden is ID 12, not 65.

12? Was it changed in 1.21.4? In optikai it was 0, in 1.21.3 optifine it was 65 and now it is 12? Make up your god damn mind :/

Also, i was able to make the sky almost gray by using a magenta color but yeah, transition is awfull then

Emfire12345 avatar Dec 04 '24 03:12 Emfire12345

It's 12 because it comes after Dark Forest which is 11. Idk how it was in the experimental phase but in 1.21.4 it's 12.

SeaOfPixels avatar Dec 04 '24 17:12 SeaOfPixels

It's 12 because it comes after Dark Forest which is 11. Idk how it was in the experimental phase but in 1.21.4 it's 12.

I would kinda prefere if they added new biome at the end of the id list... wouldnt mess up earlier version (or remap ids with an optifine feature)

Emfire12345 avatar Dec 04 '24 17:12 Emfire12345

Yup, but at least we have pack overlays now so once you update there won't be any issues with backwards compatibility.

SeaOfPixels avatar Dec 04 '24 19:12 SeaOfPixels

Yup, but at least we have pack overlays now so once you update there won't be any issues with backwards compatibility.

Am i missing something? We are not talking about layering packs but a single resourcepack, right?

Emfire12345 avatar Dec 04 '24 20:12 Emfire12345

Yes, if you are unaware we can now make overlays within a single resource pack using pack.mcmeta. Here is an example of a pack.mcmeta that implements a pack overlay:

{
    "pack": {
        "pack_format": 46,
        "description": "§6New Default+ §3v1.79: §bMC1.20-1.21.4 §7- §9SeaOfPixels"
    },
    "overlays": {
        "entries": [
            {
                "directory": "components_1.21.4",
                "formats": {
                    "min_inclusive": 43,
                    "max_inclusive": 46
                }
            }
        ]
    }
}

In this example, the pack.mcmeta is specifiying that only when playing in versions with pack format 43/44/45/46, the overlay folder components_1.21.4 should take priority over anything in assets/minecraft. This is desirable for making a pack backwards compatible when a breaking change occurs in a Minecraft update. The overlay folder components_1.21.4 is put in the root folder, the same one that assets is in, just to clarify. Hope this helps, if you have further questions I recommend asking in the Optifine discord as this sort of dicussion shouldn't be happening on a github bug report.

SeaOfPixels avatar Dec 04 '24 21:12 SeaOfPixels

Can confirm in pre13.

SeaOfPixels avatar Feb 03 '25 19:02 SeaOfPixels

Can you post an example RP?

sp614x avatar Feb 04 '25 10:02 sp614x

https://www.mediafire.com/file/u22nlc0487mzd6i/Colormap_Test.zip/file

The problem is that the game shifts the skycolor for the biome, this does not only effect the pale garden but others as well, with most of them it isnt as strong however.

I found a workaround in my pack for this issue by making the color in the colormap blue, turning into grey in the game.

Emfire12345 avatar Feb 04 '25 16:02 Emfire12345

Is this only with custom sky? Example resource pack?

sp614x avatar Feb 07 '25 17:02 sp614x

Fog could be affected as well but in my testing it was so minor that i could have been imagining it. So yes, only for the sky colormap.

Emfire12345 avatar Feb 07 '25 19:02 Emfire12345

Is this only with custom sky? Example resource pack?

Another test resource pack: NewDefault+OnlyColormapsNew.zip

SeaOfPixels avatar Feb 08 '25 03:02 SeaOfPixels

Can confirm in OptiFine 1.21.4_HD_U_J3 & OptiFine 1.21.4_HD_U_J4_pre1.

SeaOfPixels avatar Feb 18 '25 22:02 SeaOfPixels