optifine icon indicating copy to clipboard operation
optifine copied to clipboard
verified publisher icon sp614x

[Shaders] Custom sky rendering issue when using shaders

Open CeelB-2055440 opened this issue 1 year ago • 17 comments

Description of Issue

When I use optifine with a resource pack that makes use of customs skies (lets say JohnSmithLegacy), then the rendering goes wrong when optifine internal shaders are enabled.

Steps to Reproduce

Enable internal shaders Enable custom sky Enable a resourcepack that makes use of it.

OptiFine Version

OptiFine HD U J2 pre1 (1.21.3)

Installation Method

Included standalone installer

Fabric/Forge Version

N/A

OptiFabric Version

N/A

Other Installed Mods

N/A

Log Files/Crash Reports

latest.log

F3 Debug Screenshot

image

Prior Testing

In vanilla there is no problem. When shaders are disabled, there is no problem. When custom sky is disabled there is no problem.

Additional Information

Schermafbeelding 2024-10-28 192401 (You can ignore the time set 18000 (OF is set to day only))

CeelB-2055440 avatar Oct 28 '24 18:10 CeelB-2055440

Problem continues to exist in version: OptiFine HD U J2 pre2 (1.21.3)

CeelB-2055440 avatar Oct 28 '24 22:10 CeelB-2055440

Problem continues to exist in version: OptiFine HD U J2 pre3 (1.21.3)

CeelB-2055440 avatar Oct 29 '24 22:10 CeelB-2055440

I have found that it doesn't work with any shader pack.

CeelB-2055440 avatar Oct 29 '24 23:10 CeelB-2055440

Problem continues to exist in version: OptiFine 1.21.3_HD_U_J2_pre4 (1.21.3)

schrodingerspsycho avatar Oct 30 '24 12:10 schrodingerspsycho

Problem continues to exist in version: OptiFine 1.21.3_HD_U_J2_pre5 (1.21.3)

schrodingerspsycho avatar Nov 15 '24 15:11 schrodingerspsycho

"Internal Shaders" are not actually supposed to be used. They are just there for debugging purposes

ZenithRogue avatar Nov 15 '24 15:11 ZenithRogue

Renamed internal shaders to debug shaders.

sp614x avatar Nov 15 '24 16:11 sp614x

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre6 As it was stated, the problem affects all shaders, not just debug/internal ones, for example I use Sildur's Enhanced Default v1.171 Fancy, they do break in OF for 1.21.3 and do work fine with 1.21.1-OptiFine_HD_U_J1

schrodingerspsycho avatar Nov 18 '24 14:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre7 +some buggy skybox culling has appeared: 2024-11-23_00 06 06

schrodingerspsycho avatar Nov 22 '24 21:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre8

schrodingerspsycho avatar Nov 25 '24 04:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre9

schrodingerspsycho avatar Nov 25 '24 11:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre10

schrodingerspsycho avatar Nov 25 '24 19:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre11 2024-11-27_07 38 08

schrodingerspsycho avatar Nov 27 '24 04:11 schrodingerspsycho

Problem continues to exist in version: preview_OptiFine_1.21.3_HD_U_J2_pre12

schrodingerspsycho avatar Dec 02 '24 12:12 schrodingerspsycho

Seems to be fixed in preview_OptiFine_1.21.4_HD_U_J3_pre1, needs confirmation

schrodingerspsycho avatar Dec 04 '24 04:12 schrodingerspsycho

Still an issue I think? This is with BSL Shaders and Misa's texture pack, and stable release of Optifine for 1.21.3 2024-12-04_21 47 24

LaurensJV avatar Dec 04 '24 20:12 LaurensJV

Still an issue I think? This is with BSL Shaders and Misa's texture pack, and stable release of Optifine for 1.21.3 2024-12-04_21 47 24

Well, in 1.21.3 it is still an issue, but in 1.21.4 it seems to be fixed (for now)

schrodingerspsycho avatar Dec 08 '24 11:12 schrodingerspsycho