optifine icon indicating copy to clipboard operation
optifine copied to clipboard

[1.20 Feature] CIT armor culls armor trim texture where there are no pixels below

Open SeaOfPixels opened this issue 2 years ago • 1 comments

Important Update

This culling behavior was added to vanilla in 23w32a, so it will need to be made to work with CIT armor as well.

Description of the new feature

Currently armor trims show on CIT armor regardless of whether that CIT armor was designed with it in mind or not. This causes trims to float strangely on tons of CIT armor, as trims still render even if there's no armor below it in certain spots. If there was some kind of option to have parts of a trim texture cull where there is no armor texture below, this would be amazing for CIT packs and is the cleanest solution to this issue if it's possible.

Base armor CIT, no trim (a combination of different armor CIT parts that cause floating): 2023-06-23_16 39 35

Trimmed armor CIT without this feature, notice the floating trim: 2023-06-23_16 36 14

A visual mock-up of what this feature would look like, parts of the trim texture that would float are culled: 2023-06-23_16 36 28

Applicable OptiFine Versions

1.19.3 I3, 1.19.4 l4, OptiFine 1.20-pre4_HD_U_I5_pre1, OptiFine 1.20_HD_U_I5_pre3, OptiFine 1.20.1_HD_U_I5_pre6, OptiFine 1.20.1_HD_U_I5_pre7, OptiFine 1.20.1_HD_U_I6_pre6, OptiFine 1.20.4_HD_U_I7_pre2, OptiFine 1.20.4_HD_U_I7

SeaOfPixels avatar Jun 23 '23 23:06 SeaOfPixels

23w32a added this mechanic to vanilla with MC-259982, and it will need to be made to work with CIT armor.

SeaOfPixels avatar Aug 09 '23 21:08 SeaOfPixels