sozud

We have modifications to the libraries in-tree now so this doesn't make sense anymore

I think that we need to reorganize our sound effects. Given this: ``` #if defined(VERSION_BETA) #define SFX_OPEN_DOOR 0x640 #define SFX_DOOR_UNKNOWN 0x64D #else #define SFX_OPEN_DOOR 0x642 ``` `SFX_OPEN_DOOR` moved from 0x640...

I can't test it but I wrote a script to generate an enum with a comment for the vabid https://gist.github.com/sozud/59264034bd2972214cc1f27b41e49481 ``` import json with open('assets/dra/sfx.json', 'r') as f: data =...

> So would using an enum allow duplicate entries? Can you give examples of duplicates we know about?

> My biggest concern is how sound IDs tend to get reused for vastly different events or entities. For example 0x636 is used at least four different times (Teleport End...

> `800b607c` ``` LOAD_VAB(0, aPbav, g_VabAddrs[0], D_8013B6A0, vab0Len); LOAD_VAB(1, aPbav_0, g_VabAddrs[1], D_8017D350, vab1Len); LOAD_VAB(2, aPbav_1, g_VabAddrs[2], D_801A9C80, vab2Len); LOAD_VAB(3, aPbav_2, g_VabAddrs[3], D_8018B4E0, vab3Len); ``` ``` aPbav_2 = 0x800B607C; ``` The...

So are we just ignoring style now? Like no PR reviews like this? https://github.com/Xeeynamo/sotn-decomp/pull/2350#discussion_r2008896099

I haven't tried this but if you want to cut down on #includes this might help https://github.com/include-what-you-use/include-what-you-use I'm not sure I have a good sense of how much headers should...

Going to respond to this post here https://discord.com/channels/1079389589950705684/1079395108501331990/1261704573953904742 > getting sotn headers and typedefs out of psxsdk/libcd.h and psxsdk/libetc.h https://github.com/Xeeynamo/sotn-decomp/blob/master/include/psxsdk/libcd.h vs. https://github.com/sozud/psy-q/blob/master/3.5/PSX/INCLUDE/LIBCD.H Are you talking about getting rid of types.h?...

> In that case, moving types.h into psxsdk, using stdint.h (and back porting those defs for GCC 2.6) or something similar could be done. I tried finding where the s/u...