wheelmap-frontend
wheelmap-frontend copied to clipboard
Fix mapathon list loading
๐๏ธ Description
๐ก What? Why? How?
This fixes loading the mapping event list.
๐ Related Ticket
https://app.asana.com/1/1200321573365931/project/1208833037492986/task/1211034077235092
โ ๏ธ Creation checklist
Before creating this merge request, go over the following checklist (click to expand). Remove any items that are not applicable.
๐ช I have tested my code
- [ ] A new E2e playwright test covers this feature / A new test that reproduces the bug passes now.
- [ ] The feature deployment works.
- [ ] The automated tests are passing.
- [ ] I have manually tested this feature
- [ ] on mobile
- [ ] by using keyboard-only navigation
- [ ] with a screen reader (VoiceOver is fine)
- [ ] in Chrome
- [ ] in Firefox
- [ ] in Safari
๐งผ I have cleaned up my code
- [x] I have removed dependencies that were just for testing. - [x] I have removed debug logging. - [x] My code does not generate new warnings. - [x] My code does not depend on new vulnerable packages. - [ ] The commit messages are precise and make sense (rebase the PR with `--interactive` if applicable, keeping commits in sensible chunks if possible).๐ I have performed a self-review of my code
- [x] My code is self-documenting or has links to necessary documentation.
- [x] New function and variables names can be understood by new developers with basic project knowledge.
- [x] The feature fits the design.
โจ I have created a nice pull request
- [x] It has a clear title.
- [x] It follows the template, has a clear description and testing instructions if needed.
- [x] It references applicable Asana tickets.
- [x] It targets the right branch.
- [x] I removed not applicable sections of the PR template.
- [ ] [optional] I added a GIF of my favorite animal to the PR description to lighten the mood of my colleagues.
๐ I updated the documentation
- [ ] I updated the documentation in this repository.
- [ ] I updated the tech manual.
- [ ] I updated the manual testing plan of the app so that it includes a testing flow for this feature.
๐ Reviewing
When reviewing this merge request, here are some things to keep in mind:
๐ฌ Testing instructions
- Open https://wheelmap.org/events to see the issue (an error message appears)
- Open https://fix-mapathon-list-loading.wheelmap.tech/events?appId=wheelmap.org to see that the fix works (a mapping events list appears instead of the error)